GithubHelp home page GithubHelp logo

Comments (9)

 avatar commented on July 3, 2024 1

@devnoname120 I forgot a condition (modattribute & 0x7) in nids-extract. It is now fixed in ps-nids-extract.

from vita-headers.

Princess-of-Sleeping avatar Princess-of-Sleeping commented on July 3, 2024

I disagree with this.
Above all, vitasdk and vdsuite db already use different function names.
And added by using script -> vitasdk to broken again.

from vita-headers.

devnoname120 avatar devnoname120 commented on July 3, 2024

I won't overwrite function names where it doesn't make sense.
My previous iteration (#390) that merged 3 databases didn't cause any regressions and didn't break any homebrews compilation.

from vita-headers.

Princess-of-Sleeping avatar Princess-of-Sleeping commented on July 3, 2024

known problem

  1. vdsuite uses the official name as much as possible, but vitasdk does not.
    This case, Which would you choose?

  2. Removed "k" sce.
    vdsuite decided to use sce instead of ksce even for kernel functions. So need update Travis script.

But, if you ignore 1 and 2 and added them, everything will be mixed and maintenance will be very difficult.

from vita-headers.

Princess-of-Sleeping avatar Princess-of-Sleeping commented on July 3, 2024

And you made the wrong addition using a script.
https://github.com/vitasdk/vita-headers/pull/390/files#diff-f18ad1cb18f3d08fc815f05fda7da0ed3d15e0b2acd35e20e64c0ad9bc02697cR473-R483

from vita-headers.

devnoname120 avatar devnoname120 commented on July 3, 2024

Both 1 and 2 are covered in the script: https://www.github.com/devnoname120/vitasdk-db-tools/tree/master/dbtools.py

It uses a db_lookup.yml file as a reference to make sure to add to the right modules/libraries and ignore all the unknown NIDs.

Which function was incorrectly added?

from vita-headers.

Princess-of-Sleeping avatar Princess-of-Sleeping commented on July 3, 2024
      SceAppUtilBook:
        nid: 0xDA27A9D3
        kernel: true
        functions:
          ksceAppUtilBookMount: 0xFDAAF091
          ksceAppUtilBookUmount: 0x9C1794C2
      SceAppUtilAddcontForce:
        nid: 0x9D061921
        kernel: true
        functions:
          ksceAppUtilAddcontForceAddcontMount: 0x6087E5F7

These functions are user functions, but in pull/390 they were added as kernel functions.

from vita-headers.

devnoname120 avatar devnoname120 commented on July 3, 2024

@CelesteBlue-dev Any ideas why your nids-extract tool returns kernel: true for these libraries?
I used this tool to build the reference db_lookup.yml that I used to extract library names, kernel status, etc.

from vita-headers.

devnoname120 avatar devnoname120 commented on July 3, 2024

@CelesteBlue-dev Great! Feel free to take over this idea. You can base it off the script I used in my other PR.

from vita-headers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.