GithubHelp home page GithubHelp logo

Comments (9)

frouioui avatar frouioui commented on May 25, 2024 1

@GuptaManan100 vitess/go/history already has 100% coverage when I run the tests locally. Can you confirm?

@EshaanAgg, @GuptaManan100 is OOO, but I can confirm that it already has 100% of coverage on main, see the link below.

https://app.codecov.io/gh/vitessio/vitess/tree/main/go%2Fhistory

from vitess.

mattlord avatar mattlord commented on May 25, 2024

This is related to: #14932

from vitess.

beingnoble03 avatar beingnoble03 commented on May 25, 2024

Can you please assign me vitess/go/acl?

from vitess.

GuptaManan100 avatar GuptaManan100 commented on May 25, 2024

@beingnoble03 You can start working on it. When you create a PR, just mention this issue, so that if anyone else looks they know you're working on the said part.

from vitess.

beingnoble03 avatar beingnoble03 commented on May 25, 2024

@GuptaManan100 sure, thanks.

from vitess.

rajivharlalka avatar rajivharlalka commented on May 25, 2024

@GuptaManan100 I was trying to understand the number of LFX mentee's that is proposed to be taken for the upcoming term? Is it just 1 or multiple people would be participating in different parts of the project?

from vitess.

frouioui avatar frouioui commented on May 25, 2024

On #14935 we have seen that the coverage of planbuilder is not being reported. On the base branch it is reported as 0.00% which leads to Code coverage failure as soon as we modify the lines in this package and subpackages.

from vitess.

EshaanAgg avatar EshaanAgg commented on May 25, 2024

@GuptaManan100 vitess/go/history already has 100% coverage when I run the tests locally. Can you confirm?
image

from vitess.

verma-kunal avatar verma-kunal commented on May 25, 2024

Hey folks, I came upon this issue through the LFX Spring project idea page & interested to contribute here! From the issue, I understand that the main task is to add unit tests to various files under the project & improve test coverage (goal is 100%).

I'm a beginner in Go & have familiarity with very basic unit-testing through a personal project. I believe this would be a perfect way to level that up!

It would be a great help if you could point/list a few things out that would help me get me started here, to understand the project a bit more.
Thank you

from vitess.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.