GithubHelp home page GithubHelp logo

Comments (5)

mattlord avatar mattlord commented on September 19, 2024 1

/cc @vitessio/query-serving on this and the PR: #15455

from vitess.

mattlord avatar mattlord commented on September 19, 2024 1

Just noting that the results are the same on main today:

mysql> vexplain queries select * from test_vindex_signed_int where v_key in  (1,100);
+------+----------+-------+-------------------------------------------------------------------+
| #    | keyspace | shard | query                                                             |
+------+----------+-------+-------------------------------------------------------------------+
|    0 | customer | -80   | select id, v_key from test_vindex_signed_int where v_key in (1)   |
|    1 | customer | 80-   | select id, v_key from test_vindex_signed_int where v_key in (100) |
+------+----------+-------+-------------------------------------------------------------------+
2 rows in set (0.01 sec)

mysql> vexplain /*vt+ EXECUTE_DML_QUERIES */ queries update test_vindex_signed_int set id = id + 100 where v_key in (1,100);
+------+----------+-------+-------------------------------------------------------------------------+
| #    | keyspace | shard | query                                                                   |
+------+----------+-------+-------------------------------------------------------------------------+
|    0 | customer | 80-   | begin                                                                   |
|    0 | customer | 80-   | update test_vindex_signed_int set id = id + 100 where v_key in (1, 100) |
|    1 | customer | -80   | begin                                                                   |
|    1 | customer | -80   | update test_vindex_signed_int set id = id + 100 where v_key in (1, 100) |
+------+----------+-------+-------------------------------------------------------------------------+
4 rows in set (0.00 sec)


❯ vtgate --version
vtgate version Version: 20.0.0-SNAPSHOT (Git revision 3ae5cf7e690e560dd5630119215bcc3f5ecf31c8 branch 'main') built on Tue Mar 12 12:20:18 EDT 2024 by [email protected] using go1.22.1 darwin/arm64

from vitess.

harshit-gangal avatar harshit-gangal commented on September 19, 2024 1

This is not a correctness issue as it does not make the database inconsistent in any way.

from vitess.

harshit-gangal avatar harshit-gangal commented on September 19, 2024

I have removed the Bug label from it, there can be some performance improvement if the list is very big like 1000 or 10000 and we send only a limited list to each shard.

from vitess.

wangweicugw avatar wangweicugw commented on September 19, 2024

This is not a correctness issue as it does not make the database inconsistent in any way.

Understood, thank you for your explanation. My description was not accurate; this is indeed not a bug.we can still discuss how to optimize performance to be more efficient when dealing with large volumes of data.

from vitess.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.