Comments (6)
I'd be happy to take a look at implementing this @mattlord. I've started with a simple personal implementation here but am unclear how I'd actually contribute this and get it published to the container registry.
I would assume the idea would be to add vtctldclient
's container and then deprecate vtctlclient
sometime after that release?
from vitess.
Also FWIW, you can always use vtctldclient
in the vitess/lite
Docker image. We ship the binary in that image.
from vitess.
Looks good to me!
from vitess.
Thanks, @runewake2 ! I agree that we should do this. IMO, we should remove the vtctlclient
image for recent versions — as it's been deprecated since v18 — and replace it with a vtctldclient
one.
from vitess.
Hey @runewake2! The Dockerfile you are proposing looks good to me so far. You also need to update our GitHub Actions workflow that builds/pushes the Docker images. You need to add the new binary here:
from vitess.
I opened a draft PR with the changes I have + your suggestions. Unfamiliar with the process of contributing to vitess and it's changed since the last CNCF project I contributed to so please feel free to change or suggest things. I think I followed the contribution guidelines, but I might have overlooked something.
from vitess.
Related Issues (20)
- Question: Request for API to Clear Gateway Monitoring Data on Port 15001 HOT 3
- Feature Request: Add VDiff command flag for controlling row content in diff report
- Feature Request: VReplication: add force flag for SwitchTraffic and ReverseTraffic
- Feature Request: Retry vstream on a new tablet if an error is encountered
- VTAdmin: Workflow Details tab
- Bug Report: Panic in a complex query
- Bug Report: CTE names are matched against ACLs and are denied when not present
- Tablet throttler: metrics continues to be aggregated for a removed tablet
- Feature Request: LookupVindex: Warn or error on target table DDL w/o appropriate index(es)
- RFC: allow `REPLICA` using hot-backup engine to serve traffic + avoid promotion HOT 10
- Bug Report: Errors returned by LockName are not being handled properly in vtctl workflow HOT 1
- BugReport: Incorrect order of steps in SwitchTraffic
- Feature Request: Store user authentication information in etcd and support user creation syntax HOT 1
- Bug Report: primaryVindexesDiffer is returning the wrong value HOT 1
- Question: Does vitess support XA transaction? HOT 3
- Bug Report: VReplication lag is not updated when vplayer is throttled
- Feature Request: Allow innodb_lock_wait_timeout variable to be set by DB client
- Bug Report: Unexpected result when using bit-wise inversion and logical OR
- Bug Report: cutOverVReplMigration should check lock_wait_timeout otherwise it will fail if user set to low value HOT 2
- Bug Report: Query plan cache misses metric incorrect
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vitess.