Feature Request: `vitess/vtctldclient` container image about vitess

[runewake2]

I'd be happy to take a look at implementing this @mattlord. I've started with a simple personal implementation here but am unclear how I'd actually contribute this and get it published to the container registry.

I would assume the idea would be to add vtctldclient's container and then deprecate vtctlclient sometime after that release?

[frouioui]

Also FWIW, you can always use vtctldclient in the vitess/lite Docker image. We ship the binary in that image.

[frouioui]

Looks good to me!

[mattlord]

Thanks, @runewake2 ! I agree that we should do this. IMO, we should remove the vtctlclient image for recent versions — as it's been deprecated since v18 — and replace it with a vtctldclient one.

[frouioui]

Hey @runewake2! The Dockerfile you are proposing looks good to me so far. You also need to update our GitHub Actions workflow that builds/pushes the Docker images. You need to add the new binary here:

vitess/.github/workflows/docker_build_images.yml

Line 88 in 05d7e76

component: [ vtadmin, vtorc, vtgate, vttablet, mysqlctld, mysqlctl, vtctl, vtctlclient, vtctld, logrotate, logtail, vtbackup, vtexplain ]

[runewake2]

I opened a draft PR with the changes I have + your suggestions. Unfamiliar with the process of contributing to vitess and it's changed since the last CNCF project I contributed to so please feel free to change or suggest things. I think I followed the contribution guidelines, but I might have overlooked something.