GithubHelp home page GithubHelp logo

Comments (2)

MurakamiShinyu avatar MurakamiShinyu commented on June 5, 2024

In this test case, the problems on page 1 and page 2 are different. There are following two problems:

  • Problem 1: The block-start position of the first float's margin edge should be affected by the block-start margin of the first paragraph even though the float element is followed by the paragraph element, because the block-start margin of the paragraph is collapsed with the block-start margin of the body element.

  • Problem 2: The block-start margin of floats should not be discarded at unforced page breaks. The CSS spec is not clear about this, but auto-discarding the block-start margin of floats at unforced page breaks causes inconsistent look at page breaks, so we should avoid it.

from vivliostyle.js.

MurakamiShinyu avatar MurakamiShinyu commented on June 5, 2024

PR #1297 resolves Problem 2.

  • Problem 2: The block-start margin of floats should not be discarded at unforced page breaks. The CSS spec is not clear about this, but auto-discarding the block-start margin of floats at unforced page breaks causes inconsistent look at page breaks, so we should avoid it.

Test: https://gist.githack.com/MurakamiShinyu/ec57c870f6a62348a0b3f279dc4b284b/raw/float-margin-test.html

Screenshot 2024-03-03 11 13 00

from vivliostyle.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.