GithubHelp home page GithubHelp logo

Comments (11)

vladgh avatar vladgh commented on July 21, 2024 1

You're welcome. If you see any improvements please feel free to open a PR.
This discussion triggered some changes though, that I will apply later today, and they might not be backward compatible.

from docker_base_images.

vladgh avatar vladgh commented on July 21, 2024

Hey @ryanwalls, that makes perfect sense.
However, this is the intended behaviour. This script is actually downloading the files first FROM (in both modes: cron or inotify), and only after this initial step, it will start uploading files TO S3 (periodically or when files change in the 'watchdir').
Probably this is not very clear in the way I documented the code, but I'm willing to change it, to maybe accommodate both cases. One in which it just syncs to S3, and one in which it syncs from S3 first and then syncs to S3.

from docker_base_images.

vladgh avatar vladgh commented on July 21, 2024

S3Sync

from docker_base_images.

ryanwalls avatar ryanwalls commented on July 21, 2024

@vladgh Ah that makes sense. Yeah, it would be nice to have the enhancement of syncing only from host to s3 without the initial download.

from docker_base_images.

vladgh avatar vladgh commented on July 21, 2024

Instead of adding another environment variable, what about a simple check if WATCHDIR is empty or not? If it is empty do the initial download, if it has files in it then skip it.

from docker_base_images.

ryanwalls avatar ryanwalls commented on July 21, 2024

In my case I want the WATCHDIR to control the sync in all cases. So I would want the ability to disable the initial sync whether WATCHDIR is empty or not.

from docker_base_images.

ryanwalls avatar ryanwalls commented on July 21, 2024

One minor point about the inotify setup: seems we have 3 locations specified S3PATH, WATCHDIR, and DESTINATION, when we are really syncing between just 2 locations. Not sure best way to fix that or if that is intentional. Perhaps just use WATCHDIR as the destination if it is set?

from docker_base_images.

vladgh avatar vladgh commented on July 21, 2024

That DESTINATION var is redundant anyway, I will get rid of it.

from docker_base_images.

ryanwalls avatar ryanwalls commented on July 21, 2024

Just realized we actually don't need to have the WATCHDIR control the sync. Have another way to solve the problem. So I would put this as a lower priority. :)

Thanks for the tool. Looked at a lot of s3 syncs and this was the best setup.

from docker_base_images.

vladgh avatar vladgh commented on July 21, 2024

Is this working better for you?

from docker_base_images.

ryanwalls avatar ryanwalls commented on July 21, 2024

@vladgh So far so good. Thanks!

from docker_base_images.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.