Comments (11)
You're welcome. If you see any improvements please feel free to open a PR.
This discussion triggered some changes though, that I will apply later today, and they might not be backward compatible.
from docker_base_images.
Hey @ryanwalls, that makes perfect sense.
However, this is the intended behaviour. This script is actually downloading the files first FROM (in both modes: cron or inotify), and only after this initial step, it will start uploading files TO S3 (periodically or when files change in the 'watchdir').
Probably this is not very clear in the way I documented the code, but I'm willing to change it, to maybe accommodate both cases. One in which it just syncs to S3, and one in which it syncs from S3 first and then syncs to S3.
from docker_base_images.
from docker_base_images.
@vladgh Ah that makes sense. Yeah, it would be nice to have the enhancement of syncing only from host to s3 without the initial download.
from docker_base_images.
Instead of adding another environment variable, what about a simple check if WATCHDIR
is empty or not? If it is empty do the initial download, if it has files in it then skip it.
from docker_base_images.
In my case I want the WATCHDIR to control the sync in all cases. So I would want the ability to disable the initial sync whether WATCHDIR is empty or not.
from docker_base_images.
One minor point about the inotify setup: seems we have 3 locations specified S3PATH, WATCHDIR, and DESTINATION, when we are really syncing between just 2 locations. Not sure best way to fix that or if that is intentional. Perhaps just use WATCHDIR as the destination if it is set?
from docker_base_images.
That DESTINATION
var is redundant anyway, I will get rid of it.
from docker_base_images.
Just realized we actually don't need to have the WATCHDIR control the sync. Have another way to solve the problem. So I would put this as a lower priority. :)
Thanks for the tool. Looked at a lot of s3 syncs and this was the best setup.
from docker_base_images.
Is this working better for you?
from docker_base_images.
@vladgh So far so good. Thanks!
from docker_base_images.
Related Issues (20)
- [minidlna] [feature request] Add UID and GID HOT 1
- Latest docker image for minidlna does not seem to start HOT 4
- How to set translation HOT 4
- Latest image won't start (/etc/group.8: Permission denied) HOT 2
- [minidlna] How to make miniDLNA work remotely over ZeroTier? HOT 2
- [minidlna] Please bump version to 1.3.0 HOT 6
- [minidlna] /minidlna/cache/files.db on persistent volume HOT 9
- [minidlna] support timezone
- [minidlna] Ошибка работы со всеми сборками, после 0.5.0 HOT 14
- [minidlna] MiniDLNA not showing me any playlists HOT 7
- Dependency Dashboard
- Adding inotify to entrypoint.sh HOT 1
- MiniDLNA: File Permissions HOT 2
- MiniDLNA root_container HOT 3
- [MiniDLNA+podman] Health check always fails HOT 5
- Action Required: Fix Renovate Configuration
- [minidlna] BrowseContentDirectory Returning UPnPError 402 - Invalid Args HOT 1
- Healthcheck don't pass when minidlna tcp port is changed. HOT 8
- MiniDLNA. ERROR: no matching manifest for linux/arm/v7 in the manifest list entries HOT 3
- [s3sync] ModuleNotFoundError: No module named 'six' HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docker_base_images.