is_directory in procedures raises an error when touching system or special files (Windows) about irritator

[ynedelec3]

sys files seem to need being left apart when building the paths vector with directory_iterator (dialo-file.cpp line 256)

[ynedelec3]

This works with the original sort function :

void copy_files_and_directories(const std::filesystem::path& current_path)
    {
        std::error_code err;
        for (std::filesystem::directory_iterator it(current_path, err), et;
             !err && it != et;
             ++it) {

            std::string sit = it->path().string();         // Nedelec
            if (sit.find(".sys") != -1)        // Nedelec
                continue; // Nedelec

            if (it->is_directory(err) && !err) {
                paths.emplace_back(*it);
                continue;
            }

            if (it->is_regular_file(err) && !err) {
                if (have_good_extension(*it) &&
                    have_good_file_name_starts(*it)) {
                    paths.emplace_back(*it);
                    continue;
                }
            }
        }
 }

[ynedelec3]

I found another irritating file at home -) : DumpStack.log.tmp
New successful conditions are now :

if (sit.find(".sys") != -1 || sit.find("DumpStack") != -1) { // Nedelec

I can't find a generic test which could avoid calling is_directory on these special windows files

This discussion is related but does not conclude :
https://developercommunity.visualstudio.com/t/stdfilesystemis-directory-fails-with-exception-if/787098

[quesnel]

I cannot reproduce the problem. I think a best solution is to use std::error_code to avoid exception. Can you try the test branch ?

[ynedelec3]

I've succesfully generated the Test branch but the management of error codes doesn't raise an error anymore when ouput directory is selected on C:, dialog now shows a blank list of directories. I guess there is a real trouble with the status associated to these special files...

[quesnel]

I have updated the test branch. Can you test?

FWI, I force the git push, you can use git fetch origin && git reset --hard origin/test to get the patch.

[ynedelec3]

I use git functions integrated in Visual Studio, I think I got the right test branch I can see the last changes..._

I tested but file and dir list in dialog (output directory) remains empty. File and dir list in open file dialog contains directories but it is impossible to enter in any directory listed.

[ynedelec3]

It works if && ec or && ec1, && ec2 are suppressed after is_directory(..., ec...) -lines 286, 287, 293, 408, 426, 530, 545, 656-
I left it->is_directory(err) && !err unchanged in copy_files_and_directories
I can see in https://developercommunity.visualstudio.com/t/stdfilesystemis-directory-fails-with-exception-if/787098 and in https://eel.is/c++draft/fs.op.is.directory#2 cited by the former link, that is_directory with ec as argument has noexcept statement whereas is_dierctory with single path doesn't have

bool filesystem::is_directory(file_status s) noexcept;
1

Returns: s.type() == file_­type​::​directory.
🔗
bool filesystem::is_directory(const path& p);
bool filesystem::is_directory(const path& p, error_code& ec) noexcept;

[quesnel]

Ok. I think I already proposed this solution in #21 (comment)

I have updated the test branch with these changes. Can you test the test branch (again...) ?

[ynedelec3]

It works now.

I did not understand in your solution cited above that introducing error_code as second parameter would fix so simply...

[quesnel]

Cool. Thanks for the report. I merged the branches.