End of output files may come too early about irritator

[quesnel]

Hi,
In commit 81cb9da, I tried to fix the problem. Can you test the test branch ?

[ynedelec3]

Something strange happens :
with this irt file if plot output is selected, a run ends with incomplete file (last chars are ",-0.").
If plot option is then selected for the same output the end of file is immediately added (during selection, not necessary to launch a run). End of file seems to be waiting for some lost or pending commit.

[ynedelec3]

During a simulation run all values are written in file object by instruction

fmt::print(output->ofs, "{},{}\n", t, value);

in function observation_file_output_observe (simulation-ediitor.cpp)

but the disk file is only partially updated meanwhile.

observation_file_output_free (file or plot_output.free) seems to be called only during output selection, which may delay the file completion...

[ynedelec3]

Final update of file occurs just when clicking on plot button but before reaching the

plot_output& tf = plot_outs.alloc(names[i].c_str());

instruction in (node-ditor.cpp) :

            ImGui::RadioButton("none", &choose, 0);
            ImGui::SameLine();
            ImGui::RadioButton("plot", &choose, 1);
            ImGui::SameLine();
            ImGui::RadioButton("file", &choose, 2);

            if (choose == 1) {
                if (file) {
                    file_outs.free(*file);
                    sim.observers.free(mdl->obs_id);
                }

                if (!plot) {
                    plot_output& tf = plot_outs.alloc(names[i].c_str());
                    plot = &tf; ...

In simulation-editor.cpp, I guess there should be some sim.end() at the end of run_simulation which would close and update pending files.

[ynedelec3]

It works fine -)
Output files end with the exact simulation end time value.
Great thanks

[quesnel]

Cool! Thanks for the report. I will merge the branches soon.