Comments (13)
Can confirm 0.19.9 fix this issue. @vn971 Thank you for the quick response and quick fix!
from rua.
@Hs-Yeah Hi, thanks for raising the issue! My bad (insufficient testing).
I need to understand how to fix it. I'm not 100% sure that the override you're referring is the culprit (reason of the failure). I think it has been working for a while already (setting $HOME to /dev/null as recommended in man git
), but I could be wrong. Need to investigate and test properly.
If you've built rua
from source and can confirm that removing this line (or the referenced commit) fixes the issue, do tell. Otherwise I'm running similar tests now.
from rua.
I can build rua
from source, I'll test removing this line and report back later.
from rua.
@Hs-Yeah From my current understanding, the conflict is because the commit you reference eaa5910 introduces jailing for all git invocations, and the jailing script is this one: https://github.com/vn971/rua/blob/master/res/wrapper/security-wrapper.sh
This jail, however, uses the $HOME variable.
from rua.
@Hs-Yeah From my current understanding, the conflict is because the commit you reference eaa5910 introduces jailing for all git invocations, and the jailing script is this one: https://github.com/vn971/rua/blob/master/res/wrapper/security-wrapper.sh This jail, however, uses the $HOME variable.
Yes, and as my $GNUPGHOME
not set, $HOME
is used, which set to /dev/null
from rua.
On the other hand, the line 84 (that sets $HOME to /dev/null) is needed exclusively to avoid messing up with people's local git configurations (or rather, avoid being messed up by people's local git configurations). If, however, git
is being put into a jail, then the $HOME directory is cleaned anyway. So line 84 can be removed now, which I suspect will fix the issue as well.
Will test it now.
from rua.
Just for a background info if anyone might be interested. I've decided to start jailing git
operations to avoid packages being able to execute what they want when reviewing them via rua
. It is extremely unlikely that this would happen, but just to keep things clean, it's better to keep the jail constraints even in presence of .gitattributes
file.
TL&DR; Might be an overkill, but cleaner this way.
from rua.
This should fix the issue: #217
Releasing in a moment
from rua.
If you've built
rua
from source and can confirm that removing this line (or the referenced commit) fixes the issue, do tell. Otherwise I'm running similar tests now.
Can confirm that removing this line fixes this issue. I'll try 0.19.9 and report back.
from rua.
@Hs-Yeah Thanks! And thanks again for reporting!
from rua.
If you've built
rua
from source and can confirm that removing this line (or the referenced commit) fixes the issue, do tell. Otherwise I'm running similar tests now.Can confirm that removing this line fixes this issue. I'll try 0.19.9 and report back.
Oh, sorry for the false reporting, I ran the wrong command (rua upgrade
and did not entered o
to install packages, rather than rua install
directly).
With the aforementioned line removed, a new error shows up:
$ rua install rua
thread 'main' panicked at 'Command git fetch -q upstream failed with exit code Some(128)
Stderr: fatal: Not a git repository (or any parent up to mount parent /home/kozi)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
Stdout: ', src/git_utils.rs:68:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
from rua.
@Hs-Yeah yes, that's why the full PR #217 is needed I think. Try the PR (or simply 0.19.9), it should work smoothly
from rua.
@Hs-Yeah yes, that's why the full PR #217 is needed I think. Try the PR (or simply 0.19.9), it should work smoothly
I am building 0.19.9 now, will report back soon. :)
from rua.
Related Issues (20)
- Rua will not attempt to build for alternate architectures if a package is marked x86_64 only
- Allow to pass in flags to makepkg command
- Allow more fine grained controls in diff HOT 9
- Further improve file diff when upgrading package
- `rua install` doesn't work under systemd-homed user HOT 4
- Dependencies not resolved correctly for split packages
- Segfaults on search HOT 7
- Sandboxing hardening suggestions (`/mnt`, `/media`, PKGBUILD directory) HOT 2
- Decrease compilation time for updated packages HOT 1
- Patching PKGBUILD/.SRCINFO should immediately impact the dependency tree HOT 8
- RUSTSEC-2021-0139: ansi_term is Unmaintained HOT 1
- [Feature request] Add the ability to use a separate pacman.conf HOT 4
- Workflow idea: frequent builds in non-interactive throw-away VMs. Review and approve process is decoupled and allows for zero build time
- `git` command jailing and symlinked directories don't work together HOT 1
- Add completion command
- Blacklist HOT 2
- Move detached signature w/ checked tarball. HOT 1
- Dependency resolution failure with versioned dependencies, with previous versions already installed
- Internal error: queue element does not have depth
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rua.