Support for image collection tilesets about godot-tiled-importer

[SleepProgger]

The linked branch is working but i didn't send a PR yet as i am not sure how to handle some things.

ATM: i am creating a directory with the name of the tileset containing the images named like ID.png.
Should we clear the directory if it exists before or warn the user that he is overwriting existent data ?

How to handle malformed tile->image nodes (No width, height or source attributes) ?
IMHO we should err out and tell the user the file is corrupt. Granted we could "fix" missing width and height by using tileheight and tilewidth, but no chance to fix a missing source.

Your thoughts ?

[vnen]

I don't like asking for overwrites. Godot has auto-reimport, so it'll overwrite all the time when you save the map in Tiled, in which case the user wouldn't need to be bothered about it. Probably something to state in the manual and maybe in the import dialog.

At first I don't like the idea of creating an extra dir. This can be added as a new option though, as some people might prefer to use like this. Also, the image has an original name in the source, so it can keep the name when copied over.

About missing info, it depends. If Tiled always save those in the file, then you can send an error if they're missing. Otherwise, send and error only if it's irrecoverable.

Overall I like your patch. Only thing I'd add is the boolean option to save images in an extra dir with the tileset name (maybe it can even be default on). I can add that later if you're not used to that part of code though.

[vnen]

@SleepProgger BTW, sorry for the delay in my responses. I'm kind busy lately and it seems we live in disparate time zones.

[SleepProgger]

No worries about the response time, my sleep schedule is all kind of messed up anyway ;)

Your suggestion is saving the images directly in the tileset dir with its original name (if the user didn't choose to save them in an extra directory) ?
I used the extra directory to ensure that no image accidentally overwrites others.
What about naming them like TILESETNAME_ORIGINAL_NAME.png ?
That should do the trick ?

I am going to read the tiled docs about which attributes are required and add the error handling.
This means to throw the error up two more levels (in _parse_tileset and _tmx_to_dict), but i guess thats ok.

About the boolean flag: That sounds like a good idea. Will implement.

/me getting coffee and go to work

[vnen]

Your suggestion is saving the images directly in the tileset dir with its original name (if the user didn't choose to save them in an extra directory) ?

Yes, even in the extra directory they can keep the original name. Adding the TileSet name as prefix is good too.

[SleepProgger]

According to http://doc.mapeditor.org/reference/tmx-map-format/#tileset images can be embedded if the image node has a format attribute.
ATM. this case isn't handled by the plugin, but i don't think it should by anyway.
But there should be a check if the image element has a source attribute.
I could add it for both cases (tileset image and tile image) while i am at it.

I guess implementing loading embeded images from tmx files wouldn't be that hard to implement, but i don't really see the benefit tbh.

[vnen]

Fixed by #9.