"/bin/sh: 1: -i: not found" (apprise e-mail error) about free-games-claimer

[Xansala]

Thanks @blackpanther989,
Just tried it again following your scheme but I am getting the same error. The password is an alpha-numeric one, there are no special characters in there.

It looks like that the games claimer script is not putting quotes around the apprise command when executing it and then with the "&" in the command URL, the command line seems to interpret it which results in the error.

[blackpanther989]

surround your mailtos in quotes EX: "mailtos://{e-mail account}:{password}@gmx.de?user={e-mail address}&smtp=mail.gmx.com&to={target e-mail}"

That fixed it for me.

[Xansala]

Hi @blackpanther989 ,

Thanks for the hint! I am providing the mailtos through the NOTIFY variable, i.e. NOTIFY="mailtos ...". There I am using the quotes and also tried apostrophe but both result in the same error (also double or triple quotes do not work).

docker run --rm -p 6080:6080 -v fgc:/fgc/data --pull=always -e NOTIFY="mailtos://{e-mail account}:{password}@gmx.de?user={e-mail address}&smtp=mail.gmx.com&to={target e-mail}" ghcr.io/vogler/free-games-claimer

[blackpanther989]

Hi @blackpanther989 ,

Thanks for the hint! I am providing the mailtos through the NOTIFY variable, i.e. NOTIFY="mailtos ...". There I am using the quotes and also tried apostrophe but both result in the same error (also double or triple quotes do not work).

docker run --rm -p 6080:6080 -v fgc:/fgc/data --pull=always -e NOTIFY="mailtos://{e-mail account}:{password}@gmx.de?user={e-mail address}&smtp=mail.gmx.com&to={target e-mail}" ghcr.io/vogler/free-games-claimer

I also had an issue with this as well and it was that my password contained something that broke the parsing. but other then that I wouldn't know what else would be breaking it.

Mine is entered as: "mailtos://{email}?smtp={smtpserver}&user={username}&pass={password}" and I'm using gmail.

[vogler]

free-games-claimer/util.js

Line 94 in a7cc68b

exec(`apprise ${cfg.notify} -i html '${title}' -b '${html}'`, (error, stdout, stderr) => {

NOTIFY was not quoted, so if yours contained something that must be escaped on the shell, it made it fail. You could have put escaped quotes around it.
I just switched to execFile which takes arguments as an array, so there should be no more shell-escape issues. (exec just spawned a shell to execute the command whose arguments then need to be properly escaped.)