GithubHelp home page GithubHelp logo

Comments (10)

vogler avatar vogler commented on May 23, 2024 1

Exit code fixed in 704c4b0.
Do you have some details? For me the locator finds the button.

from free-games-claimer.

gitrep3 avatar gitrep3 commented on May 23, 2024 1

Thank you! I will try to reproduce it when I am back at my laptop

from free-games-claimer.

gitrep3 avatar gitrep3 commented on May 23, 2024 1

Okay I gave it a try and it consistently presented me the timeout:

games-claimer-epic-1  | Xvfb display server created screen with resolution 1280x1280
games-claimer-epic-1  | VNC is running on port 5900 (no password!)
games-claimer-epic-1  | noVNC (VNC via browser) is running on http://localhost:6080
games-claimer-epic-1  | 
games-claimer-epic-1  | 2023-02-21 20:50:12.223 started checking epic-games
games-claimer-epic-1  | Signed in as gitrep3
games-claimer-epic-1  | locator.waitFor: Timeout 20000ms exceeded.
games-claimer-epic-1  | =========================== logs ===========================
games-claimer-epic-1  | waiting for locator('a:has(span:text-is("Free Now"))').last() to be visible
games-claimer-epic-1  | ============================================================
games-claimer-epic-1  |     at file:///fgc/epic-games.js:96:25 {
games-claimer-epic-1  |   name: 'TimeoutError'
games-claimer-epic-1  | }
games-claimer-epic-1 exited with code 1

Exit code triggered my own notification system so that works flawlessly now 🥳

I tried connecting to noVNC to see what is happening but everything was waaaay to slow, when my browser finally loaded the VNC it already exited, so I increased the environment TIMEOUT=60 and this seems to fix the issue for me.
I triggered it several times now and didn't get the error anymore.

Container is running on a very low performance hardware, I think its either that or my shitty internet connection.

Thanks for your quick response and this project in general!

from free-games-claimer.

gitrep3 avatar gitrep3 commented on May 23, 2024 1

20s gave me flaky results for both Epic and Gog (not using prime at all), it was a little worse for Epic, I guess because they use more JS on their site.

if 20s had a 50% chance to succeed, maybe 30s would have been enough but i don’t really see the appeal for it. On my productive automation I increased if even higher to 120s because I don’t care how long it takes as long as it is not completely stuck.

Maybe someone can run it on a Raspberry Pi to see how long it takes, that should be the most widespread host for such scripts I would say

from free-games-claimer.

gitrep3 avatar gitrep3 commented on May 23, 2024 1

And today it reliably claimed the free game for this week, very cool!

from free-games-claimer.

vogler avatar vogler commented on May 23, 2024

Can't reproduce. The text of the button changed to Weekly games, but data-type="Game" is still the same.
Can you check with SHOW=1 what's happening?

from free-games-claimer.

gitrep3 avatar gitrep3 commented on May 23, 2024

I have the same issue, unfortunately is also exits with code 0 so my script thinks everything worked fine.

from free-games-claimer.

vogler avatar vogler commented on May 23, 2024

The low TIMEOUT of 20s was mainly for development and due to the fact that it was high enough for the machines I tried.
I can increase the default value to something more suitable for these kind of machines. Do you have a tighter bound than 60s? Otherwise I'll just set it to that.
Aside: I use a free Oracle VPS and it's pretty fast: https://www.mydealz.de/deals/kostenloser-arm-server-mit-4-cpus-24gb-of-ram-and-200gb-storage-2096200

@Kraker01 can you confirm TIMEOUT=60 working for you as well?

from free-games-claimer.

Kraker01 avatar Kraker01 commented on May 23, 2024

Timeout partially solved the problem, now i got this:

Current free game: Duskers
  Not in library yet! Click GET.
page.click: Timeout 60000ms exceeded.
=========================== logs ===========================
waiting for locator('[data-testid="purchase-cta-button"]')
  locator resolved to <button class="css-1ppwb5u" data-testid="purchase-cta-bu…>…</button>
attempting click action
  waiting for element to be visible, enabled and stable
  element is visible, enabled and stable
  scrolling into view if needed
  done scrolling
  performing click action
============================================================
    at file:///C:/Users/***/Downloads/free-games-claimer/epic-games.js:136:18 {
  name: 'TimeoutError'

I'm using the latest version download (the one updated 16hrs ago)

from free-games-claimer.

vogler avatar vogler commented on May 23, 2024

@Kraker01 Yes, I got the same, see #62.
So, I can close this since prime-gaming works now for you with the increased timeout? What hardware are you running it on?

from free-games-claimer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.