GithubHelp home page GithubHelp logo

Comments (5)

NyaGarcia avatar NyaGarcia commented on May 16, 2024 6

First of all, we'd like to thank you for opening and participating in this issue.

We have not been able to find any evidence of npkill deleting any files apart from node_modules, nor have we been able to replicate this behaviour (not for lack of trying.)

What we have realised, after hours of testing, is that some applications, such as Visual Studio Code, Discord, Postman etc. have their own node_modules directories that enable them to work correctly. Therefore, when using npkill's --delete-all flag, these node_modules directories are also deleted. This can cause the aforementioned applications (and any other application that stores its dependencies in a node_modules directory) to fail or have unexpected behaviours, like messing up VS tooling.

Despite the fact that this is annoying and can cause a great deal of trouble, the --delete-all flag is working as expected, since it is searching for and automatically deleting every single node_modules directory it finds.

Even so, we have reached the conclusion that this flag can be dangerous and can cause problems. Therefore, we have chosen to remove it from npkill.

from npkill.

duongdev avatar duongdev commented on May 16, 2024 2

Yes, all of my projects are gone. Just installed latest version ([email protected]). Ran npkill -D on home directory.

You should take down this project or display a BIG warning before the problem is investigated and solved.

image

from npkill.

shennan avatar shennan commented on May 16, 2024 2

Perhaps a list of everything that would be deleted as a result of this flag as a sanity check, then requiring a simple "Y" input to confirm such deletions? It's pretty annoying having to cycle through everything with space bar. And then if one takes longer, you need to cycle back up to check it's been deleted before quitting the runtime.

from npkill.

zaldih avatar zaldih commented on May 16, 2024

First of all, I deeply regret what happened.
Please, could you provide me with all the possible information?

  • Program version (npkill -v)
  • OS
  • The steps prior to the event
  • If possible, the route from which you ran npkill
  • Remember if during the event, all the directories in the list were shown?

Before launching the first version to the public, we did thousands of tests to test that none of this could happen.

Are you completely sure that the problem has been caused by npkill?

from npkill.

duongdev avatar duongdev commented on May 16, 2024

It deleted not only my projects but everything under my home. The Projects/targeek still there because I was running a web server there while running npkill -D.

image

And iCloud too

image

from npkill.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.