v3 unexpected whitespace removal about htmlmin

[voku]

I think the problem is already fixed with version 3.0.0 (take a look at the tests -> https://travis-ci.org/voku/HtmlMin/builds/323025901), but you need to update "voku/simple_html_dom" >= 4.1.3. With version 3.0.1 we will now force this vendor update.

[Bilge]

It seems I was using 4.1.3.

  - Removing voku/portable-utf8 (4.0.1)
  - Updating voku/simple_html_dom (4.0.1 => 4.1.3): Downloading (100%)
  - Updating voku/html-min (2.0.4 => 3.0.0): Downloading (100%)

[voku]

Your example is added as unit-test and it is ok 👌 at Travis CI (php 7.0 - 7.2) and also on my local system (Ubuntu + php 7.0.x).

If it's still a problem for you, maybe you can detect your current libxml2 version? Because this library is used by php for dom interactions.

[Bilge]

Whitespace before anchors are definitely being removed.

Before

<span>foo</span>                                         <span>bar</span>                                                                                                                         <a>baz</a>                                                                                 <a>bat</a>

After

<span>foo</span> <span>bar</span><a>baz</a><a>bat</a>

Note that the foo span is needed for the space to be deleted before the baz tag. Maybe the presence of this extra tag is breaking some special-casing code. Since there is whitespace before each of the <a> tags in the source there should still be a single whitespace before each of the output tags.

Using

• voku/html-min: 3.0.1
• voku/simple_html_dom: 4.1.3

[Bilge]

Why closed?

[voku]

I added tests (28 Jan) that passed on travis-ci and on my local laptop, so I can't fix a test that did not fail :/ ... or did I miss something in the test?!

[Bilge]

I assure you there remain outstanding issues.

…

On Tue, 18 Dec 2018, 00:15 Lars Moelleken ***@***.*** wrote: I added tests (28 Jan) that passed on travis-ci and on my local laptop, so I can't fix a test that did not fail :/ — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#16 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAcuYsUYMhWNDfl_7xWbEGe52H5hyOyaks5u6DOrgaJpZM4RPFdY> .

[jordanade]

I'm still experiencing this issue!