GithubHelp home page GithubHelp logo

Comments (4)

voku avatar voku commented on May 27, 2024

Thanks for the bug report, fixed in version 3.1.6

from htmlmin.

ozupey avatar ozupey commented on May 27, 2024

It looks like any occurrence of {{ will cancel minification.

It seems to be on purpose, but I'm not sure why: https://github.com/voku/simple_html_dom/blob/master/src/voku/helper/HtmlDomParser.php#L947

If I disable that line, it minifies just fine and I'm not seeing any negative effects.

<script type="text/html">
	{{foo}}

	{{bar}}

	{{hello}}
</script>

Will result in:

string(63) "<script type=text/html>	{{foo}}

	{{bar}}

	{{hello}}
</script>"

from htmlmin.

ozupey avatar ozupey commented on May 27, 2024

It would be nice if there was at least an option to force minification of these special tags, perhaps disabled by default. :)

from htmlmin.

voku avatar voku commented on May 27, 2024

Hi and thanks for the bug report (again) 👍 ... fixed in version 4.4.0. Here is an example: 9a88a5c#diff-468b8a043eb54ed31edbee53141c1512R769

from htmlmin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.