GithubHelp home page GithubHelp logo

Comments (5)

voku avatar voku commented on May 27, 2024

thanks for the bug report, fixed in version 4.5.4 of the simple-dom-lib... but you can also use <html amp> like this https://amp.dev/documentation/guides-and-tutorials/start/create/basic_markup?format=websites

from htmlmin.

scones avatar scones commented on May 27, 2024

your fix now produced <html ____simple_html_dom__voku__google_amp____=true> which is invalid again

from htmlmin.

voku avatar voku commented on May 27, 2024

I added a test case... 🤔 but maybe you are using the lib a different way, so can you share a minimal example or even better a pull request with a failed test? Thanks.

from htmlmin.

scones avatar scones commented on May 27, 2024

well, my config looks like in the example of the docu here:
https://github.com/vmpublishing/slim-html-minify

maybe it is a utf8 problem somewhere.
🤔

from htmlmin.

voku avatar voku commented on May 27, 2024

my fault :/ ... I didn't tested it via HtmlMin (I only fixed and tested it via SimpleHtmlDom) but HtmlMin will remove the quotes from a helper string ...="true" vs. ...=true.

Fixed in version 3.1.8 of HtmlMin (f7256e7)

from htmlmin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.