Comments (7)
Thanks for the bug report, 👍 fixed in version 4.4.2.
from htmlmin.
Hi,
I wrote this test after the last commits. It fails.
public function testKeepPTagIfNeeded2()
{
$html = '
<div>
<p>
<span>First Paragraph</span>
</p>
Loose Text
<p>Another Paragraph</p>
</div>
';
$htmlMin = new voku\helper\HtmlMin();
$result = $htmlMin->minify($html);
$expected = '<div><p><span>First Paragraph</span> </p> Loose Text <p>Another Paragraph</div>';
static::assertSame($expected, $result);
}
I'm not sure about the whitespaces in the $expected
string. But I am sure about the missing </p>
tag.
from htmlmin.
I think perhaps the closing </p>
tag can only be omitted if the <p>
node is immediately followed by another <p>
node or if it's the last node. But I haven't thought this through. Perhaps there are other edge-cases.
from htmlmin.
@abuyoyo yep, and we can ignore some cases where only whitespace are in middle of nothing ... I could simplify the logic. What do you think? -> 67d39fb
from htmlmin.
Yeah. That looks good.
As for the whitespaces, I'm pretty sure a single non-breaking-space must be preserved on either side of the Loose Text
if it was there in the original html.
" Loose Text "
!= "Loose Text"
However:
<p><span></span> </p>
evaluates the same as <p><span></span></p>
(the space before the </p>
can go)
The same goes for <div><p>Text </div>
which I believe evaluates to <div><p>Text</div>
.
And the whitespace handling is obviously a separate (and minor) issue.
If I remember correctly, whitespace only needs to be preserved between <li>
elements in case someone sets their css to display:inline
in which case <li></li><li></li>
!= <li></li> <li></li>
from htmlmin.
Ooh.
I was half-wrong.
<div><p>Text </div>
is NOT the same as <div><p>Text</div>
from htmlmin.
So, in fact
<div>
<p>Text</p>
</div>
should minify to <div><p>Text</div>
and NOT to <div><p>Text </div>
(which is the current implementation).
from htmlmin.
Related Issues (20)
- HtmlMin cut html at the end of page HOT 12
- Incorrect processing before and after<nocompress> tag HOT 1
- <p> paragraphs break when compressing, closing tag missing HOT 7
- Whitespace/ommited tags fidelity issue + headless browser testing proposal
- Remove data attributes in tag
- Remove new lines in script type=application/ld+json
- More issues with <code> and <p> HOT 1
- Minify inline Javascript
- PRCE error handling HOT 5
- how to pass html & from where HOT 1
- Dependency Dashboard
- Escaping issues with Mustache.js templates HOT 2
- `doMakeSameDomainsLinksRelative` somewhat counter-intuitive
- Broken minification (`ParseError`)
- Unexpected whitespace removal before anchor tag
- Broken script template tags HOT 2
- Doesn't work in php 8 or greater due to namespaces not being Capitalized
- `sizes` and `srcset` value are not trim...
- Uncaught TypeError with PHP 8.3 and `id` attribute HOT 4
- removing end head tag </head> from file...
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from htmlmin.