Comments (2)
Hi, thanks for the questions / observations.
- The non-conditional space doesn't make the generated markup invalid. The recommended implementation also includes the extra space if the properties dictionary is empty.
- The recommended implementation would raise a
StopIteration
exception if theitems
sequence is empty. That can of course be easily fixed and I also agree that this specific part could be better implemented. At the same time, the code works correctly.
And also, can i know why you create a copy of the separator object each time you yield it?
If separator
is a callable, then it'll be called every time (as it should) and the return value will be added -- the callable itself can always return the same object, although in many cases you'll want different instances to add unique node keys for example, it depends on the use-case and the user. If separator
is an ElementType
instance, then sep
will be a method that always returns that specific object (see line 41), there are no extra instantiations at all, since there's nothing to instantiate.
On the other hand, sep = lambda: separator()
(line 30) could be simplified to sep = separator
, the extra lambda is not necessary at all. This would be a tiny optimization though.
from markyp.
Closing for lack of activity.
from markyp.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from markyp.