Comments (10)
Hmmm, I changed to script that generates the facts to use the ruby provided by puppet AIO package instead off all the mess here: e9e7dc7
So the problem is that rubysitedir
is not the one you expect?
from facterdb.
So the problem is that rubysitedir is not the one you expect?
Yes, I suppose it simply came as a surprise to see it change for that OS on pre-existing tests. Now I think about it more, that's inevitable as AIO becomes the standard and you update the facts for the OS. As you add a new set of facts for a new facterversion, what's returned by r-p-f will change.
I wonder if it's feasible to not ever refresh facts (esp between non-AIO and AIO) for a given facterversion once it's been released in facterdb?
We probably ought to simply stub/merge the facts we expect in the specs better either way.
from facterdb.
Isn't it possible to populate it at runtime in rspec-puppet-facts like I do for augeasversion
, rubyversion
and puppetversion
https://github.com/mcanevet/rspec-puppet-facts/blob/master/lib/rspec-puppet-facts.rb#L45-L49?
from facterdb.
@domcleal what do you think of that voxpupuli/rspec-puppet-facts#19 ?
from facterdb.
I don't think overwriting it from r-p-f is going to help much, since it's probably just going to change it to an RVM path or something about where the tests are run rather than the Puppet/Facter packages that were used.
Let me close this issue because I think we need to do it via merging/stubbing of the facts in our test. I'm not sure that we can assume which type of packages these facts use.
from facterdb.
@mcanevet maybe a more generic override framework would also solve voxpupuli/rspec-puppet-facts#14
from facterdb.
@ekohl I'm not sur how to implement this, but PR welcome :-)
@domcleal I release rspec-puppet-facts
1.3.0 that dynamically set rubysitedir, does it solve your problem?
from facterdb.
@mcanevet yes it does, thank you. I'm still not sure that we should be relying on it, as I suspect it's now setting the rubysitedir to /home/dcleal/.rvm rather than either /usr/lib or /opt/puppetlabs, but it is fixing the tests.
from facterdb.
@mcanevet what would be the correct place to discuss the issue? I'm quite sure it's not here :)
from facterdb.
@ekohl probably here voxpupuli/rspec-puppet-facts#14
from facterdb.
Related Issues (20)
- RHEL 7 os.release.full values are incorrect HOT 1
- Overriding BSD architecture or missing OS entirely HOT 1
- facterdb conflict HOT 2
- FacterDB appears to not give a os.family for solaris 11 on facter 4 HOT 2
- New gem release required prior to Puppet 7 to resolve dependency issues HOT 1
- Include CentOS 8 stream facts HOT 7
- Add AlmaLinux HOT 9
- Several OS files under version 4.2 are missing the mountpoints fact HOT 5
- Regression test to verify factsets have required facts HOT 2
- service_provider centos 7 HOT 3
- Factsets for FreeBSD 13 have a blank hostname HOT 2
- ubuntu facts from 21.04 are missing the aio_agent_version fact. HOT 2
- IP addresses are different on RedHat and other distributions
- Debian 12 support
- Failed to add new OS support due to errors when `vagrant up --provision` HOT 4
- Script to check if newly generated facts are significantly different
- Architecture Support HOT 2
- CHANGELOG format
- 2.0.1 release summary
- Add Support for Ubuntu 24.04 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from facterdb.