centos-7-x86 facts in 0.2.2 changed to AIO about facterdb

[mcanevet]

Hmmm, I changed to script that generates the facts to use the ruby provided by puppet AIO package instead off all the mess here: e9e7dc7

So the problem is that rubysitedir is not the one you expect?

[domcleal]

So the problem is that rubysitedir is not the one you expect?

Yes, I suppose it simply came as a surprise to see it change for that OS on pre-existing tests. Now I think about it more, that's inevitable as AIO becomes the standard and you update the facts for the OS. As you add a new set of facts for a new facterversion, what's returned by r-p-f will change.

I wonder if it's feasible to not ever refresh facts (esp between non-AIO and AIO) for a given facterversion once it's been released in facterdb?

We probably ought to simply stub/merge the facts we expect in the specs better either way.

[mcanevet]

Isn't it possible to populate it at runtime in rspec-puppet-facts like I do for augeasversion, rubyversion and puppetversion https://github.com/mcanevet/rspec-puppet-facts/blob/master/lib/rspec-puppet-facts.rb#L45-L49?

[mcanevet]

@domcleal what do you think of that voxpupuli/rspec-puppet-facts#19 ?

[domcleal]

I don't think overwriting it from r-p-f is going to help much, since it's probably just going to change it to an RVM path or something about where the tests are run rather than the Puppet/Facter packages that were used.

Let me close this issue because I think we need to do it via merging/stubbing of the facts in our test. I'm not sure that we can assume which type of packages these facts use.

[ekohl]

@mcanevet maybe a more generic override framework would also solve voxpupuli/rspec-puppet-facts#14

[mcanevet]

@ekohl I'm not sur how to implement this, but PR welcome :-)
@domcleal I release rspec-puppet-facts 1.3.0 that dynamically set rubysitedir, does it solve your problem?

[domcleal]

@mcanevet yes it does, thank you. I'm still not sure that we should be relying on it, as I suspect it's now setting the rubysitedir to /home/dcleal/.rvm rather than either /usr/lib or /opt/puppetlabs, but it is fixing the tests.

[ekohl]

@mcanevet what would be the correct place to discuss the issue? I'm quite sure it's not here :)

[mcanevet]

@ekohl probably here voxpupuli/rspec-puppet-facts#14