GithubHelp home page GithubHelp logo

Comments (3)

electrical avatar electrical commented on July 20, 2024

Hi,

the config file is managed indeed by the module.
any reason for not managing it?

from puppet-elasticsearch.

ctrlaltdel avatar ctrlaltdel commented on July 20, 2024

Hi Electrical,

Sorry for the incomplete explanation. The trouble is that after this puppet run the file /etc/elasticsearch/elasticsearch.yml only contained " ### MANAGED BY PUPPET ###\n" whereas I expected it to contain the actual configuration.

From the puppet agent log, you can see that the resource named Stage[main]/Elasticsearch::Config/File[/etc/elasticsearch/elasticsearch.yml] has its content changed twice. My conclusion is that the bug comes from Puppet interpreting the ERB template content in two different ways, the first time with access to the settings variable but not the second time.

Here's what the applied recipe contains.

  class { 'elasticsearch':
    pkg_source  => "/tmp/elasticsearch-${es_version}.deb",
    require     => [ Package['openjdk-6-jre-headless'], Exec['download_elasticsearch'] ],
    autoupgrade => true,
    config      => {
      'network' => {
        'host'  => '127.0.0.1',
      }
    }
  }

I hope that it now makes sense?

from puppet-elasticsearch.

electrical avatar electrical commented on July 20, 2024

strange that it would be an issue. i do test against 2.7.x ( 2.7.23 in this case ) and get no errors at all.
Also the config file resource is only managed once.
There is also only 1 event scheduling the refresh of the service.

but i accept the patch as it didn't break anything.

from puppet-elasticsearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.