Comments (6)
dirname does exist in stdlib, but not in the 3.x series (only in 4.x). Currently PE only supports the 3.x series so we can't reliably use the dirname function. Your solution would work for this - would you be able to send a PR?
from puppet-jenkins.
Looks like 4.x is supported by PE, but they might need to manually update. 4.x is still compatable with Puppet 2.7, despite original plans..
might be worth considering, sooner or later..
from puppet-jenkins.
Awesome - what versions of PE support 4?
Maybe we put this in as a post 1.0? Make the next version require stdlib >= 4.0?
from puppet-jenkins.
v3.0.x (Released in PE 3)
v4.0.x (Maintains compatibility with v3.x despite the major semantic version bump. Compatible with Puppet 2.7.x)
(from https://github.com/puppetlabs/puppetlabs-stdlib )
However, it doesn't ship with PE 3, so.. yeh.
I don't have PE, but i don't know if it breaks if you update PE's stdlib to a newer verison than it ships with.
from puppet-jenkins.
A couple guys said you can't upgrade it (PL and former) with PE because of how tightly it's coupled, that's why I was curious what version. My thinking was the same as yours - puppet is supported, go for it.
That being said, I think for this either the inline_template or leave it as it is solutions are the most portable. I can do this later if the OP doesn't have time.
from puppet-jenkins.
I'm pretty sure this can be closed with the merge of #102
from puppet-jenkins.
Related Issues (20)
- Plugin download / installation not idempotent HOT 1
- Add a way to set the open files limit in systemd service HOT 1
- Error HOT 1
- Error HOT 1
- Support: casc HOT 1
- Jenkins is no longer forking (--daemon has been removed) HOT 2
- Does no longer work with jenkins 2.332.1 or 2.335 onwards
- Support for Jenkins < 2.332 HOT 1
- Fact 'jenkins_plugins' can exceed value length limit: 4096 HOT 2
- Convert Terminology to match current Jenkins Terminology HOT 1
- Puppet removes plugin when plugin was installed using the Jenkins ui
- How to install jenkins on a mounted partition HOT 1
- Class jenkins::slave : Rights issues on the jenkins-slave file with systemd
- Non-atomic default plugins update can cause havoc.
- Removes quotes from $JAVA_ARGS, otherwise java fails to start
- Jenkins Redhat repo certificate has expired HOT 2
- undefined method strip HOT 8
- jenkins_plugins fact is locale-dependent which can cause a plugin installation loop HOT 2
- jenkins-cli.jar has been renamed in the jenkins rpm. HOT 6
- jenkins present.pp does not fix single-quotes for xml 1.1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppet-jenkins.