Option to clean up cronjobs for removed domains about puppet-letsencrypt

[Dan33l]

It looks we didn't release it but what do you think about ensure_cron attribute ?
https://github.com/voxpupuli/puppet-letsencrypt/blob/master/manifests/certonly.pp#L51

[cFire]

That's only half the puzzle. I'm using the pre-release version from git but it will still try to exec { "letsencrypt certonly ${title}":, which is no good if the domain is gone.

Perhaps we can add a normal ensure attribute which just takes 'absent/present'? That way we have a neat way both to clean up old certs, and to clean up cron jobs and scripts if enabled.

[Dan33l]

You are right.

Can you propose a PR for this enhancement ?

[cFire]

Sure. I'll try to fit it in somewhere this week. But I think the older manage_cron attribute may then be more aptly named again rather than the ensure_cron from 3.0.1-rc1. And as an added bonus if we change it back, it would still be backward compatible with puppet code using the 3.0.0 release.

[Dan33l]

Yes, it looks possible.

[cFire]

Created #177 to see if you agree on the general changes made. Still needs testing and need to think if there's a nicer way to do the exec{} and file{} rather than wrapping them in an if/else.

[Dan33l]

Fixed by PR #17