replace server urls with v2 urls about puppet-letsencrypt

[Dan33l]

Hi @hboetes

Why modify the default value of $config does not meet your needs ?

[hboetes]

The code should use sane defaults and in this case use the working server URL, not the outdated one. Your proposal would force all users of the module to fix that problem for themselves whereas the maintainer can fix the problem for everyone.

[ekohl]

With reading those sources I agree we should be defaulting to v2. I also wonder why we even set a default rather than relying on the hardcoded defaults. Probably because we use ini_setting and don't purge.

[hboetes]

@ekohl I can imagine setting staging as the default, since I’ve never managed to get a cert in one go and use the production one as the non-default, with a switch like: production => true
I also see no reason for using anything else but hard coded URLs.