Upgrade from 4.x to 5.x, Downgrade from 5.x to 4.x about puppet-nodejs

[igalic]

👍 @fstr!
would you like to provide us with a pull request?

[fstr]

I was working with the 0.8.0 release from puppetlabs, you should publish a new release there!

But the problem seems to persist/be slightly different for the latest 1.3.0 release.

When I change the repo_url_suffix from 4.x to 5.x, the sources.list.d file is updated, but no apt-get update is executed. A notify => Exec['apt_update'] when changing the sources.list entry seems to be propagated to be executed AFTER apt-get install

With the change I proposed providing a certain version, the install fails because of the missing apt-get update.

The best fix I found so far, is doing a require => Exec['apt_update'] in install.pp for each package to make sure, that the required versions are available after providing the sources.list.

Example:

  # nodejs
  package { $nodejs::nodejs_package_name:
    ensure => $nodejs::nodejs_package_ensure,
    require  => Exec['apt_update']
  }

I'll try to provide a PR later.

[igalic]

I was working with the 0.8.0 release from puppetlabs, you should publish a new release there!

@fstr puppetlabs/nodejs has been moved to voxpupuli (on the forge this is the /puppet namespace)
we're working together with puppetlabs to make pmt and the forge do redirects.

[juniorsysadmin]

Proposed fix merged in #198