GithubHelp home page GithubHelp logo

Comments (2)

vpetrigo avatar vpetrigo commented on August 30, 2024

Hello @sg-james,

Thank you for the report and a PR! I will take a look at your changes.

from caches.

sg-james avatar sg-james commented on August 30, 2024

I managed to create a simple test case that catches the bug

TEST(FIFOCache, Remove_Test_FifoRemoveBug_issue21) {

    constexpr std::size_t TEST_SIZE = 3;
    fifo_cache_t <std::string, std::size_t> fc(TEST_SIZE);

    for (std::size_t i = 0; i < TEST_SIZE; ++i) {
        fc.Put(std::to_string(i), i);
    }
                                                          // CachePolicy { 2, 1, 0 }        CacheMap { 0, 1, 2 }
    const int specific_key = 1;
    EXPECT_TRUE(fc.Remove(std::to_string(specific_key))); // CachePolicy { 2, 1 } -> 0      CacheMap { 0, 2 }

    fc.Put(std::to_string(3), 3);                         // CachePolicy { 3, 2, 1 }        CacheMap { 0, 2, 3 }
    fc.Put(std::to_string(4), 4);                         //             { 4, 3, 2 } -> 1   CacheMap.erase("1") // error

    EXPECT_EQ(fc.Size(), TEST_SIZE);
}

My PRs approach trades complexity for memory, but perhaps an O(n) removal lookup would be preferable to a second data structure?

from caches.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.