Fitz Dark Italic theme not showing up about web

[jschr]

This is the error that I'm seeing when trying to parse the theme:

SyntaxError: Unexpected token } in JSON at position 29836

Unfortunately the error isn't super helpful but you can test it out here: https://repl.it/@jschr/fitz-dark-italic-vscode-theme.

All I'm doing is stripping out comments and running JSON.parse.

[sheafitzek]

Thanks for the feedback. I'll have to try to debug it tomorrow evening.

[jschr]

Np, let me know what you find.

[sheafitzek]

Turns out I had a lot of hanging commas in my theme json. I wonder why the marketplace didn't throw any errors at me when I uploaded it. So are you pulling theme info for your site from the marketplace or github?

[jschr]

Thanks for digging into this.

I'm pulling it from github but I'd like to remove the github dependency and download extensions directly from the marketplace. Tracking that in #93.

The marketplace isn't throwing an error because it's not trying to load the source of the theme. That happens in VSCode when the user installs the extension. My guess is VSCode is using require to load in the theme, which allows for comments and trailing commas.

I'm using JSON.parse because require is unsafe to use at the server. I'd like to find a way to remove trailing commas, just like I'm removing comments. Tracking that in #123.

[sheafitzek]

My theme has been updated in the marketplace, along with my master branch. The repl.it linked above is no longer throwing errors, but I still don't see my theme on your site.

[jschr]

The sync only runs every 8 hours. I'm pushing through an update to strip trailing commas—I'll run it manually after #124 is merged. Your theme will show up shortly after that.

[jschr]

https://vscodethemes.com/e/sheafitzek.fitz-dark-italic-vscode-theme

[sheafitzek]

I see it now. Thanks for all your help. There is one small discrepancy I see, but I'll open a separate issue for it. You can close this one down now.