Keybinding discussion (non-US mostly) about vim

[AntonAderum]

Let me know if you have any questions, I realize this became quite long and maybe over complicated.
Maybe I spent to much time thinking about it but I felt like it could use a discussion. I will create a PR where you can see the changes together.

[jpoon]

Hey @AntonAderum.

I think what you suggested is the best course of action. For whatever keys the extension wishes to handle, they need to be registered with VSCode in the package.json and a respective handler defined in extension.ts.

[guillermooo]

Just a quick note that we may not need the internal key translation done by VSCodeVim any more. I've fallen behind with the current status regarding key handling in VS Code, though, so this is just a heads-up.

[jpoon]

@guillermooo 😮

What's the new way of handling these things then?

[AntonAderum]

@jpoon Great!

@guillermooo
As far as I can tell (with what i have been reading last few days) you will still need to take internal key and translate it to the proper key via handlers. I'd be delighted if it wasnt the case though.

[kedare]

I saw some issues of this kind, for example on my keyboard (Spanish) pushing ":" is like pushing ">" (or "<", I don't remember) when using the VIM plugin (And I never had any other problem of this kind somewhere else in VSCode), this is quite a problem :)

[jpoon]

Closing this issue as VSCode has made some great headway in handling international keyboards: #432. We've actually removed our own keyboard mapper in favor of letting VSCode handle the dirty work.

If you don't think that is the case, please re-open this issue.