Comments (7)
Let me know if you have any questions, I realize this became quite long and maybe over complicated.
Maybe I spent to much time thinking about it but I felt like it could use a discussion. I will create a PR where you can see the changes together.
from vim.
Hey @AntonAderum.
I think what you suggested is the best course of action. For whatever keys the extension wishes to handle, they need to be registered with VSCode in the package.json and a respective handler defined in extension.ts.
from vim.
Just a quick note that we may not need the internal key translation done by VSCodeVim any more. I've fallen behind with the current status regarding key handling in VS Code, though, so this is just a heads-up.
from vim.
What's the new way of handling these things then?
from vim.
@jpoon Great!
@guillermooo
As far as I can tell (with what i have been reading last few days) you will still need to take internal key and translate it to the proper key via handlers. I'd be delighted if it wasnt the case though.
from vim.
I saw some issues of this kind, for example on my keyboard (Spanish) pushing ":" is like pushing ">" (or "<", I don't remember) when using the VIM plugin (And I never had any other problem of this kind somewhere else in VSCode), this is quite a problem :)
from vim.
Closing this issue as VSCode has made some great headway in handling international keyboards: #432. We've actually removed our own keyboard mapper in favor of letting VSCode handle the dirty work.
If you don't think that is the case, please re-open this issue.
from vim.
Related Issues (20)
- Help Command
- Placing marker does not work when creating mapping (but works in regular vim)
- vscodevim stopped working sometimes until reinstalling the extension HOT 2
- Could not move the cursor to previous/next line with 'h' and 'l' under visual mode HOT 1
- vit operation error selected character > HOT 3
- Sticky Scroll partially breaks zt
- Ignoring slipped selection after scrolling down extremely fast
- I couldn't mapping. HOT 1
- Cursor moves to last mouse click after pasting a yanked line
- When switching files in the Explorer, you cannot use the k key to move up and select a file. HOT 1
- E353: nothing in register 🔡 HOT 1
- Support `:b[uffer] {bufname}`
- There is a bug in the paste and mark commands when using macros
- `editor.action.smartSelect.expand` doesn't affect VIM selection
- `workbench.action.gotoSymbol` doesn't move cursor HOT 1
- how to remap the <leader> p to "0p in normal mode? HOT 2
- Cursor moves to a wrong location when selecting lines in visual block mode
- `:w` feels noticeably slower than `Cmd+S` HOT 1
- im-select in local machine should be used when connecting to remote machine over vscode ssh plugin.
- Cursor freeze in normal mode in large codebase
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vim.