GithubHelp home page GithubHelp logo

Comments (4)

staticcat avatar staticcat commented on September 28, 2024

I wonder if being more verbose here would fix the issue. It would also mean reading the tests would clearer. I suggest:

class procedure WillRaise(const AMethod : TTestLocalMethod; const exceptionClass : ExceptClass; const msg : string = ''); overload;
class procedure WillRaiseDescendant(const AMethod : TTestLocalMethod; const exceptionClass : ExceptClass; const msg : string = ''); overload;
class procedure WillRaiseAny(const AMethod : TTestLocalMethod; const msg : string = ''); overload;

Also should the Assert.CheckExceptionClass() procedure be changed to have its gate condition to throw an invalid argument exception?

from dunitx.

vincentparrett avatar vincentparrett commented on September 28, 2024

If you are checking that a method throws an exception under certain circumstances, then you are probably expecting a specific exception, in which case, the current WillRaise behaviour is correct. Jason's idea has merit though, and would be backwards compatible.

from dunitx.

LarsFosdal avatar LarsFosdal commented on September 28, 2024

Jason's approach is satisfactory.

from dunitx.

rlove avatar rlove commented on September 28, 2024

Lars, hopefully my changes will work for you.

from dunitx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.