Safari fatal error about nprogress

[fundon]

Could you add an example for that?

[wouterNL]

import nprogress from 'nprogress'

function install (Vue) {
  if (this.installed) return
  this.installed = true

  Object.defineProperty(Vue.prototype, '$nprogress', {
    get: function get () { return this.$root._nprogress }
  })

  Vue.mixin({
    beforeCreate: function beforeEach () {
      const np = this.$options.nprogress
      if (np) {
        this._nprogress = np
        np.init(this)

        if (Vue.http) {
          Vue.http.interceptors.push(function (request, next) {
            np.inc(0.2)
            next(function (response) {
              np.done()
              return response
            })
          })
        }

        const router = this.$options.router
        if (router) {
          router.beforeEach(function (route, redirect, next) {
            np.start()
            next()
          })
          router.afterEach(function () {
            np.done()
          })
        }
      }
    }
  })
}

function NProgress (options) {
  this.app = null
  this.configure(options || {})
}

NProgress.prototype.init = function (app) {
  this.app = app
}

NProgress.install = install

Object.setPrototypeOf(NProgress.prototype, nprogress)

export default NProgress

To:

import nprogress from 'nprogress'

function install (Vue) {
  if (this.installed) return
  this.installed = true

  Object.defineProperty(Vue.prototype, '$nprogress', {
    get: function get () { return this.$root._nprogress }
  })

  Vue.mixin({
    beforeCreate: function beforeEach () {
      var np = this.$options.nprogress
      if (np) {
        this._nprogress = np
        np.init(this)

        if (Vue.http) {
          Vue.http.interceptors.push(function (request, next) {
            np.inc(0.2)
            next(function (response) {
              np.done()
              return response
            })
          })
        }

        var router = this.$options.router
        if (router) {
          router.beforeEach(function (route, redirect, next) {
            np.start()
            next()
          })
          router.afterEach(function () {
            np.done()
          })
        }
      }
    }
  })
}

function NProgress (options) {
  this.app = null
  this.configure(options || {})
}

NProgress.prototype.init = function (app) {
  this.app = app
}

NProgress.install = install

Object.setPrototypeOf(NProgress.prototype, nprogress)

export default NProgress

The reason this is not working is because the node-modules is not getting pulled through the web-pack compiler to convert ES6 to ES5.

[wouterNL]

I just checked you other project: Vue Admin
That one is having the same problem in Safari.

[fundon]

Which version is your safari?

[wouterNL]

Version 9.1.2

[fundon]

Version 10.0.1 (12602.2.14.0.1) is ok.

Could you post a PR? 😀

[wouterNL]

May I ask why you don't have any minified versions of your plugins, that are pulled through web pack? That way you also solve the problem for older browsers. Because IE9> also doesn't support it.

[fundon]

I think this issue will be fixed when building source codes on production with webpack.

[fundon]

@wouterNL Landed in 0c6a4aa.