GithubHelp home page GithubHelp logo

Comments (7)

yyx990803 avatar yyx990803 commented on May 4, 2024

I'm not sure if fake rendering is really a good idea. Mocking sounds super fragile and I doubt it can be really that lightweight if we want to make sure things don't just break.

Maybe we can tackle this from a different perspective - is it possible to statically analyze and extract queries at build time (kinda like Relay Modern)?

from core.

Akryum avatar Akryum commented on May 4, 2024

Well, that's the approach taken by the official react-apollo (source). BTW it seems so much easier to do in React 😭

from core.

yyx990803 avatar yyx990803 commented on May 4, 2024

It looks quite fragile/hacky to me, and is essentially rendering the whole app twice... which means it decreases performance significantly... not sure if it's worth it at all.

That said it's totally possible in v3.

from core.

yyx990803 avatar yyx990803 commented on May 4, 2024

Also, it seems it cannot have nested components with queries. The walker stops when any component has async data. Still quite a limitation IMO.

from core.

Akryum avatar Akryum commented on May 4, 2024

Maybe we could make renderToString asynchronous with ways to hook into it and do data prefetching and eventual secondary re-rerenders of components that prefetched some data?

from core.

Akryum avatar Akryum commented on May 4, 2024

BTW react-apollo switched to rendering the app multiple times: apollographql/react-apollo#2533

from core.

Akryum avatar Akryum commented on May 4, 2024

Closing in favor of #11

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.