GithubHelp home page GithubHelp logo

Comments (10)

Mister-Hope avatar Mister-Hope commented on May 5, 2024

This feature is not hard to add. But I am curious about why you need this feature.

Logos can be images which it's color can be too light in darkmode(or too dark in lightmode), so I added that darkLogo option.
But font icons only have shapes, and it's color should be adjusted when switching between darkmode and lightmode.

So why do you need to change to another icon in darkmode?

from vuepress-theme-hope.

ItsBioDude avatar ItsBioDude commented on May 5, 2024

Oh, sorry. I though that you can add a darkIcon and then add darkStyle and Style (for light mode) to make it render like this: <i class="fal fa-quidditch" style="color: #f06595;"></i> but I h the a better idea that we just need to add
darkStyle (for styles in darkmode) and Style(for lightmode)

Why

Well, have a look at my site, the reddit icon in darkmode look doesn't good because of its color but in lightmode, it look great in lightmode so adding a way to change the color of icons in dark/light mode is great

image

image

from vuepress-theme-hope.

Mister-Hope avatar Mister-Hope commented on May 5, 2024

Do you like the icon color or not?

If not, I think it's possible for you to add in your index.styl

.iconfont::before
  color inherit

If above has issues, you can add important:

.iconfont::before
  color inherit!important

from vuepress-theme-hope.

ItsBioDude avatar ItsBioDude commented on May 5, 2024

I really love the icon color in light mode but it doesn't look good at darkmode so I just want to change the icon's color in darkmode into another color

from vuepress-theme-hope.

Mister-Hope avatar Mister-Hope commented on May 5, 2024

Besides, I regard these icons as decorations, and I am not expecting users take a look time configurating them. So I would prefer them to be the same as text color. If you do want a full control to the icon, I will add some options like iconStyle add darkIconStyle.

Note: Having colorful icons maybe strange when you hover or active them.

from vuepress-theme-hope.

Mister-Hope avatar Mister-Hope commented on May 5, 2024

Hey here, I just realize you are configuring contact. There is a component for you to add those links:

image
image

from vuepress-theme-hope.

ItsBioDude avatar ItsBioDude commented on May 5, 2024

Oh, yeah I know that but it doesn't support some platform: gitlab, bitbucket, reddit so I choose to add a small dropdown item on the nav bar

from vuepress-theme-hope.

Mister-Hope avatar Mister-Hope commented on May 5, 2024

You can leave the icons you want, I can add them in the next version.

Any icons you want besides gitlab, bitbucket, reddit?

from vuepress-theme-hope.

ItsBioDude avatar ItsBioDude commented on May 5, 2024

Can you add discord as well. Thanks

image

from vuepress-theme-hope.

Mister-Hope avatar Mister-Hope commented on May 5, 2024

The four icons were added in 0.8.0

from vuepress-theme-hope.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.