vytas7 / falcon-sqla Goto Github PK
View Code? Open in Web Editor NEWSQLAlchemy session management middleware for Falcon applications.
Home Page: https://falcon-sqla.readthedocs.io/
License: Apache License 2.0
SQLAlchemy session management middleware for Falcon applications.
Home Page: https://falcon-sqla.readthedocs.io/
License: Apache License 2.0
As communicated by @CaselIT , automatically choosing a write engine if the session is currently flushing (automatically enabled by default, see SessionOptions.write_engine_if_flushing
) is apparently not bullet proof (as explained in sqlalchemy/sqlalchemy#5407 (comment) ).
This was implemented along the lines of a DIY recipe from SQLAlchemy docs. Revise what the options are. If we fail to improve this to cover the majority of common scenarios, it might be worth changing the default to False
to not give a false sense of safety.
In any case, falcon-sqla
, if configured, is normally choosing read/write engines according to the HTTP method for the Falcon request in question, and write_engine_if_flushing
is provided just as an edge case fallback, so the impact of this bug should be somewhat limited.
The default logic, commit on success, rollback on failure is a sensible one
falcon-sqla/falcon_sqla/middleware.py
Lines 53 to 56 in e4d7865
maybe it could be useful to add the ability of a resource to customize this logic.
I'm not sure how to best implement it. Probably a function in the resource class that returns what to do (commit, rollback, nothing) is the best solution.
The test suite, although hitting 100% branch coverage, is a bit chaotic at the time of writing.
I've cleaned up DB fixtures in conftest.py
, so they're probably good enough as-is.
Clean up the tests, add more cases logically testing typical usage rather than just hitting all lines.
Currently when read_from_rw_engines
or write_to_rw_engines
are False and no engine is read-only or write-only all the engine are used.
falcon-sqla/falcon_sqla/manager.py
Lines 41 to 44 in b75af08
This behavior is quite strange, since the option is not respected.
Raising an error in this case would probably be more appropriate, the problem with the exception is that by adding the engines one by one it's easy to encounter an error while adding them.
I'm not sure how to best support this scenario.
One option is to make the engine selection lazy, so that only on the first use we check for this, the user does not have an immediate feedback with this approach
We should support falcon v3
See also: falconry/falcon#658
Split off from #7.
Write a short tutorial on how this could be used with a Falcon application in order to reduce the amount of boilerplate code.
falcon-sqla
wraps streams using ClosingStreamWrapper
.
This class does not have a read attribute, and it causes falcon to not use the wsgi_file_wrapper
https://github.com/falconry/falcon/blob/2556abce9afd9e0ea55d6aada09c64c311ca688e/falcon/api.py#L832
This can lead to large performance regressions when the stream is a file, since it can get iterated over one byte at the time.
See Pylons/waitress#291
Write a short tutorial, and Aggregate docstrings into reference docs.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.