Comments (4)
@ylafon Ping.
from css-validator.
Ah, looks like this uses Apache Ant.
Perhaps I'll try Mavenizing this.
from css-validator.
Perhaps I'll try Mavenizing this.
Please don’t spend any time actually doing that until @ylafon weighs in on this. I’m not 100% certain how if feels about switching the build to maven but I would bet that he would prefer not to do that. I personally would also strongly prefer not to do that. I recognize what some of the advantages of maven are for certain kinds of projects, but I don’t think this is one of those kinds of projects (yet).
The advantages of continuing to use ant include:
- If it ain’t broke, don’t fix it. There may be some issues or brokenness with the current build but if so don’t think they are serious, and if/when we identify any, it would be better to just fix them instead of completely replacing/rewriting the build.
- Ant has less dependencies and complexity. I am no big fan of ant either. But relative to the alternatives for building Java, it has much fewer dependencies and less complexity. Sure that also makes it less powerful. But we don’t need anything powerful for this build. And sure, ant may be less elegant (or whatever), but it’s not a beauty contest. We already have something that as far as I can tell is working as expected (modulo whatever issues we might identify)—as ugly as it might be.
from css-validator.
Yeah, step 1 is of course to fix the existing Ant build script; #15 does that.
I can't speak to number of dependencies. Maven would certainly be less tedious; a bunch of the JAR filenames are repeated in 5 places in the Ant build whereas they'd only be referenced once in a pom.xml
. There is also mindshare to consider. This is admittedly anecdotal, but my impression is that Ant isn't too popular these days compared to Maven for Java projects, so it's a little extra barrier to entry (e.g. I had to install Ant on my box just for this); YMMV of course. I agree that Maven can definitely get complex if you're doing complex things, but as you say, css-validator's build is extremely vanilla.
from css-validator.
Related Issues (20)
- Incorrect css shows as correct HOT 1
- False errors "The types are incompatible" and "Invalid type" HOT 3
- wrong _allowed_values in css3/CssListStyleType
- Possible false validation error "Property d doesn't exist." HOT 1
- Validator doesn't support space as value for custom property HOT 1
- Media query causes unexpected parse error HOT 1
- :has() expects initial combinator when none is required
- 'rotate', 'scale' CSS properties incorrectly reported as 'doesn't exist' HOT 1
- Unrecognized at-rule "@layer"
- CSS variable in clamp() without default value HOT 1
- `filter: invert()` is invalid
- False error in custom variable declaration HOT 1
- False positive error about text-wrap:balance HOT 10
- Cast exception when validating @font-face rule with CSS level 2 profile
- Possible false validation error "Property overflow-clip-margin doesn't exist"
- box-shadow: value none
- Shorthand hexadecimal values are not recognized in custom properties
- Validator does not recognize "background-color" and "fill" properties with custom values HOT 1
- Unrecognized at-rule @container
- Property container doesn't exist
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from css-validator.