GithubHelp home page GithubHelp logo

Comments (7)

richtr avatar richtr commented on August 12, 2024

This relates to the discussion starting at #21 (comment).

@foolip wrote:

My hope is that there wouldn't be any reason to use [existing input events for multimedia keys].

Ideally MediaSession should replace handling for multimedia input events.

For platforms that do currently fire multimedia key events we have three options:

  1. fire multimedia key events against active media sessions. If no active media session is present, fire them as multimedia input events.
  2. fire multimedia key events against active media sessions. If no active media session is present, do not fire multimedia input events at all.

The other proposal is to fire media session events after keyboard events:
3. fire keyboard multimedia key events normally and if they are not preventDefault()ed then continue to fire them again at active media sessions, if any.

Of the three options, my preference would be on (2). Once we know the order we want to fire these events (or if we want to continue firing multimedia key events as input events at all) I think we can start to look at the event timing/ordering text we need to add to the spec.

from mediasession.

mounirlamouri avatar mounirlamouri commented on August 12, 2024

We need implementer feedback on this. I'm not sure what the timing should be and whether cancelling a key event should block the media session action. At the moment, Chrome did not implement an action that is also a key event so I prefer not to write something in the spec without any implementation feedback.

from mediasession.

foolip avatar foolip commented on August 12, 2024

@jernoble, there's some chance you'll be the first to try to tie actions to keys on a keyboard, any thoughts?

FWIW, I can see two relative sane options:

  1. If the keypress is will translate to a MediaSession action, it isn't delivered as a KeyboardEvent at all.
  2. A KeyboardEvent is fired, and only if the event isn't canceled does the MediaSession action happen.

from mediasession.

foolip avatar foolip commented on August 12, 2024

Ping @jernoble?

from mediasession.

jernoble avatar jernoble commented on August 12, 2024

AFAICT, I don't think that the media buttons will ever generate key events on Mac platforms. That they're on the keyboard (on non-Touch Bar Macs) is coincidental.

from mediasession.

youennf avatar youennf commented on August 12, 2024

I think @jernoble comment still holds on Apple platforms.
If there is no change in implementations where a keypress might trigger both an event and a media session action, we could document this in the spec.
Marking as "Ready for PR" for now.

from mediasession.

youennf avatar youennf commented on August 12, 2024

Closing, given the spec has been rewritten to no longer talk about key press and so on.

from mediasession.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.