GithubHelp home page GithubHelp logo

Comments (23)

xfq avatar xfq commented on September 13, 2024 1

Submitted speced/bikeshed#1073 and speced/bikeshed#1074.

from motion-sensors.

dontcallmedom avatar dontcallmedom commented on September 13, 2024

@anssiko the key is not the "Status:" bit in the document, but the one in the command line invokation ( --md-status=NOTE).

I tried publishing it myself with that fixed, but there is another bug with the document - it sounds like it doesn't use the proper boilerplate to link it to the DAS WG.

from motion-sensors.

alexshalamov avatar alexshalamov commented on September 13, 2024

@dontcallmedom is "Group: dap" not enough to link it to DAS WG?

from motion-sensors.

dontcallmedom avatar dontcallmedom commented on September 13, 2024

@alexshalamov it probably would if we had the right boilerplate for Notes in bikeshed, but it looks like we don't - I'm assuming the boilerplate would be needed to tell which group is producing the Note. At the same time, I see that we got the previous note published without that mention, so I'm a bit puzzled.

@xfq any chance you could investigate, maybe with @tripu 's help?

from motion-sensors.

tripu avatar tripu commented on September 13, 2024

It looks like Specberus is not finding the deliverer(s) of this spec.

Specberus finds the deliverer okay in the latest published version, though.

Can you guys share with me the resulting NOTE (the output of Bikeshed for the current ED; what goes inside the TAR file submitted to Echidna)? That may help debug the issue.

from motion-sensors.

xfq avatar xfq commented on September 13, 2024

@tripu Here's the resulting NOTE. For Some Reason™ the Status section looks empty... Like @dontcallmedom said, perhaps we do not have the right boilerplate for Working Group Notes in Bikeshed.

(I compressed the tar file with zip, because GitHub doesn't support .tar file upload.)

test.tar.zip

from motion-sensors.

tripu avatar tripu commented on September 13, 2024

Thank you, @xfq. Yes, the SotD section is empty.

These are the patterns Specberus uses to identify the deliverers:
w3c/specberus:/lib/validator.js#L340-L343

The SotD is okay in the version published currently. Did you guys change anything after that?

from motion-sensors.

alexshalamov avatar alexshalamov commented on September 13, 2024

@tripu If I remember correclty, the only 'boilerplate' related change was 0d846e0 Level: 1 => Level: none and 00eae02 link to previous version.

from motion-sensors.

xfq avatar xfq commented on September 13, 2024

It seems that we don't have a status-NOTE.include file in the Bikeshed boilerplate: https://github.com/tabatkins/bikeshed/tree/master/bikeshed/boilerplate/dap

However, the CSS WG doesn't have it either, and it has WG Notes published with Bikeshed: https://www.w3.org/TR/css-2017/

And I don't know how the previous note was published...

from motion-sensors.

xfq avatar xfq commented on September 13, 2024

I saw a <div boilerplate=status> element in the CSS WG Note: https://github.com/w3c/csswg-drafts/blob/eee458baa78b4aabd57da71a192ea88e7cff1ecd/css-2017/Overview.bs#L26-L30

I'll try to add a similar one to motion-sensors and generate a tar file to see if it works.

from motion-sensors.

xfq avatar xfq commented on September 13, 2024

It still doesn't work... Strangely, the background-image on the left is https://www.w3.org/StyleSheets/TR/2016/logos/NOTE instead of https://www.w3.org/StyleSheets/TR/2016/logos/WG-Note

I'll investigate further later.

from motion-sensors.

xfq avatar xfq commented on September 13, 2024

Spent a few hours on this issue... Although I haven't found the source of the issue (yet), I just found out that the Status section of the previous Note was added (and patched) manually by @anssiko:

So this doesn't seem to be a new issue. Maybe I should ask @tabatkins for help...

from motion-sensors.

xfq avatar xfq commented on September 13, 2024

(I'll continue to look for ways to publish this document automatically, instead of patching it manually each time.)

from motion-sensors.

anssiko avatar anssiko commented on September 13, 2024

@xfq, thanks for your hard work debugging this issue. When you have all the required upstream changes landed to fix the publication issue, feel free to publish an updated Working Draft on our behalf using the latest Editor's Draft at https://w3c.github.io/motion-sensors/ as its basis.

(I had entirely forgotten that I had to manually patch the spec previously in order to publish it.)

from motion-sensors.

xfq avatar xfq commented on September 13, 2024

@anssiko I patched the style sheet manually to pass the publication rules this time.

For automatic publishing, I think we still need to wait speced/bikeshed#1073.

from motion-sensors.

anssiko avatar anssiko commented on September 13, 2024

speced/bikeshed#1073 was fixed and closed but https://github.com/w3c/motion-sensors/blob/gh-pages/echidna.sh still reports https://lists.w3.org/Archives/Public/public-tr-notifications/2017Aug/0130.html specifically "You are not participating in the following groups:" and "You are not authorized to publish" errors.

@xfq, thanks for your help.

from motion-sensors.

dontcallmedom avatar dontcallmedom commented on September 13, 2024

I have identified one more change needed in bikeshed.

note that the echidna.sh script will need to use WG-NOTE rather than NOTE. Also, my last attempt to publish with echidna (with the bikeshed patch in) failed with messages about the version links that I haven't looked into.

from motion-sensors.

anssiko avatar anssiko commented on September 13, 2024

@dontcallmedom, thanks! I updated echidna.sh in this repo accordingly.

from motion-sensors.

dontcallmedom avatar dontcallmedom commented on September 13, 2024

found the source of the other failure, and filed a related bikeshed issue

from motion-sensors.

dontcallmedom avatar dontcallmedom commented on September 13, 2024

I've been able to publish an updated version of the note out of the bikeshed processing as speced/bikeshed#1081 got fixed, but there is one last issue in bikeshed to be solved for our script to work as is

from motion-sensors.

anssiko avatar anssiko commented on September 13, 2024

Thanks for your efforts. I though this was just something I had overlooked, but it turns out we've now had to fix 4 bikeshed issues (to date), consolidated here, should we run into related problems in the future:

from motion-sensors.

dontcallmedom avatar dontcallmedom commented on September 13, 2024

speced/bikeshed#1083 got merged, and I have now successfully run echidna.sh, so closing this issue

from motion-sensors.

anssiko avatar anssiko commented on September 13, 2024

Thanks!

from motion-sensors.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.