Storing content in browser local storage does not work properly / sporadically loses changes without local storage about ckeditor-textselection-plugin

[w8tcha]

What errors are you getting? and which browser did you use?

[roadlittledawn]

i of course cannot reproduce the local storage error right now, but i believe it was a cannot read length of null at line 342 which is:

var diff = content.length - savedContent.length;

the local storage error occurred in Chrome (Version 63.0.3239.84 (64-bit)) and Firefox 57.0 (64-bit).

i can still reproduce losing data when switching between Source and WYSIWYG modes. that also happens in those version of Chrome and Firefox. right now, looks like it loses data when switching from WYSIWYG to Source mode. it correctly saves content when switching from Source to WYSIWYG. if i remove the local storage code, it works most of the time. occasionally, users have noticed missing content when switching between Source and WYSIWYG.

are there version requirements to use this? we are on codemirror plugin 1.17.4 and sourcearea plugin 4.5.11. our Drupal ckeditor module version is 1.17 (the ckeditor version our drupal module is running is 4.5.6).

[roadlittledawn]

also, FWIW: with the local storage code removed, i think the intermittent missing data issue may be related to the browsers caching the old version of the plugin's javascript. i changed the timestamp token in this line of code in ckeditor/ckeditor/ckeditor.js file (drupal module path) to force browser to get latest file and it seems to work in local and dev environments.

d={timestamp:"20180103"...

[w8tcha]

i added some checks that should avoid the issues with the localstorage