GithubHelp home page GithubHelp logo

Pre-Condtion in `sqb/compile-schema` suggests only `columns` and `idents` is needed, but fails later for several other keys about walkable HOT 3 CLOSED

walkable-server avatar walkable-server commented on April 28, 2024
Pre-Condtion in `sqb/compile-schema` suggests only `columns` and `idents` is needed, but fails later for several other keys

from walkable.

Comments (3)

myguidingstar avatar myguidingstar commented on April 28, 2024

Great discovery! I think the above three should not be mandatory.
flatten-multi-keys should only be applied after checking for non nil. Eg:

(flatten-multi-keys extra-conditions)

should become

(when extra-conditions
  (flatten-multi-keys extra-conditions))

are you willing to make another pr? :)

from walkable.

christoph-frick avatar christoph-frick commented on April 28, 2024

What about putting them in the :or as empty maps?

:or {quote-marks backticks}

from walkable.

myguidingstar avatar myguidingstar commented on April 28, 2024

that should work, too. Maybe that would save us from some null point exception headaches that I can't contemplate atm

from walkable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.