Planar Reflections issue with non-standard shaders using transparency about crest

[daleeidd]

That image looks like OceanPlanarReflections > Clear Flags is not set to Skybox. Unless your skybox does not write alpha which would be strange. Try testing with Unity's procedural skybox.

[daleeidd]

Perfect. That could be a combination of fresnel and colours blending.

I'll make Skybox the default as prefer to have things work over an optimisation. I'll document this in the tooltip and somewhere in the documentation too.

[daleeidd]

Does changing the Clear Flags to Skybox solve it?

[Revmatek]

Does changing the Clear Flags to Skybox solve it?

Changing the Clear Flags does not seem to have an effect. The clear flags for the image above is with Skybox.

[daleeidd]

Is that on the OceanPlanarReflections script? Otherwise can you remove the * saturate(refl.a) and see if it improves from the following line:

crest/crest/Assets/Crest/Crest/Shaders/OceanReflection.hlsl

Line 29 in 0be7cca

io_colour = lerp(io_colour, refl.rgb, _PlanarReflectionIntensity * saturate(refl.a));

[Revmatek]

OceanPlanarReflections

This is OceanPlanarReflections script, yes. Disabling saturate does have an effect and makes the tree leaves appear, but causes other more obvious problems with reflections / darkness on the surface

[Revmatek]

That image looks like OceanPlanarReflections > Clear Flags is not set to Skybox. Unless your skybox does not write alpha which would be strange. Try testing with Unity's procedural skybox.

It seems unrelated to the skybox. I tried it with default and a few others. Doesn't change. It also does not seem related to OceanPlanarReflections being on

[daleeidd]

Can you provide a screenshot of the OceanPlanarReflections component?

[Revmatek]

Can you provide a screenshot of the OceanPlanarReflections component?

[Revmatek]

Can you provide a screenshot of the OceanPlanarReflections component?

Well I guess that solves that mystery. I was not aware you were referring to Clear flags on this script vs the camera.

Thanks for the help!

[daleeidd]

No worries. Does it work correctly if you remove the reflection alpha modification?

[Revmatek]

No worries. Does it work correctly if you remove the reflection alpha modification?

Yes, it does appear to be working correctly now.

It does seem to wash out a bit after I stop moving the camera but it is mostly fine. Definitely an improvement.

Seems to depend on the angles and only with trees

I'm not sure why there is a distinction between the transparency in the standard shaders and the custom / tree shaders, obviously depends on what each shader is doing I guess.

[daleeidd]

Fixed in 4.20.