GithubHelp home page GithubHelp logo

Comments (11)

karsyboy avatar karsyboy commented on May 22, 2024

Something like this, please!!!
capture

from waveboxapp.

karsyboy avatar karsyboy commented on May 22, 2024

all that was done in this electron code is they disabled the windows from and then used a css script to make a nice style one on top.

from waveboxapp.

Thomas101 avatar Thomas101 commented on May 22, 2024

Hi @karsyboy thanks for getting in touch. Now that I have more time to spend on Wavebox, I can start to work on things like this. As Wavebox supports more than just Google inbox, having a title that bleeds in like the screenshot is probably not going to work as when you switch across to gmail you'll be left with the blue or a constantly changing colour bar.

There's probably a few options here...

  1. Add the window buttons into the same position as what they are on osx. This does have the downside that the icons are on the wrong side. Probably quite annoying. On the plus side though doesn't take any extra screen estate.
  2. I can add in a title bar for windows and give it a generic color. This comes at the expense of screen estate though.
  3. Same as 2, but could try to pick the default coloring used by the user

It would be good to get some feedback on what you think on this

from waveboxapp.

karsyboy avatar karsyboy commented on May 22, 2024

I like the idea of making it what its like in osx and would not mind this the design is clean and in my own option having it on the other side isnt a big deal.
I also like the idea os being able to change the tittle bar color in setting.
But to be honest im not a 100% sure on which one I just know the design in windows with the frame and everything else going one makes it look weird.

from waveboxapp.

Thomas101 avatar Thomas101 commented on May 22, 2024

Lets look at adding it into a similar position as OSX first and then see how that works. We can always re-look at adding in a stylized titlebar as a further option later on

from waveboxapp.

weaversam8 avatar weaversam8 commented on May 22, 2024

I'd +1 this issue. Having Wavebox also change the title bar color based on the app open could be a great solution as well. If you look at the beta channel of the Slack desktop app for Windows, it uses CSS to create a Windows 10-esque bar that matches the team style.

from waveboxapp.

Thomas101 avatar Thomas101 commented on May 22, 2024

This has been added into 3.1.4 which is now live. It's still a little bit experimental, but you can enable it by going to settings and toggling Show Titlebar to off. Would be great to have some feedback on this, I think there's still a little bit more work to do on this feature

Wavebox should update automatically after a while, but if you want to hurry it up, just restart the app and it will re-check

from waveboxapp.

weaversam8 avatar weaversam8 commented on May 22, 2024

This is more what I had in mind, but what you did is certainly a start. I think this is more of an opinionated topic.

image

from waveboxapp.

Thomas101 avatar Thomas101 commented on May 22, 2024

I think there's room for both here - as you said opinionated topic. Will re-open and look at adding a bar option

from waveboxapp.

nmat avatar nmat commented on May 22, 2024

going to test this and get back with result

from waveboxapp.

nmat avatar nmat commented on May 22, 2024

Here is the github desktop app layout also which is interesting:

image

from waveboxapp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.