wayfair / psvaultutils Goto Github PK

https://github.com/wayfair-contribs/psVaultUtils/blob/b83838d94e0c3800ccec508f335f2b458330773f/psVaultUtils/Public/RootTokens/Unprotect-VaultRootToken.ps1#L30

The $Otp parameter needs a parameter description.

Towards the bottom of the README, there is a formatting issue with the ordered list. Markdown does not respect ordered lists that start with a 0th step. Renumber the steps such that 0th element in the list becomes the 1st element in the list.

Apparently, use of Invoke-Expression is a poor practice because in a worst-case scenario it can open up the potential for code injection.

We can replace the strings expressions with script blocks, and invoke them with Invoke-Command.

The following functions use Verbs that are designated as changing system state, but do not currently support ShouldProcess.

The functions should be updated to support ShouldProcess:

• Start-VaultRootTokenGeneration
• Stop-VaultRootTokenGeneration
• Set-VaultKVEngine
• New-VaultCubbyholeSecret
• Remove-VaultCubbyholeSecret
• New-VaultKVSecret
• Start-VaultRekey
• Stop-VaultRekey
• Stop-VaultRekeyVerification
• New-VaultToken
• New-VaultWrappedToken
• Set-VaultLoginToken
• Update-VaultToken
• Set-VaultSessionVariable
• New-VaultWrapping
• Update-VaultWrapping