GithubHelp home page GithubHelp logo

some question about server.js [29] about hichat HOT 4 CLOSED

wayou avatar wayou commented on June 15, 2024
some question about server.js [29]

from hichat.

Comments (4)

wayou avatar wayou commented on June 15, 2024

have u tested ?

from hichat.

startprogress avatar startprogress commented on June 15, 2024

sorry, I was wrong. I checked it again. The original code was right.

from hichat.

startprogress avatar startprogress commented on June 15, 2024

And there is another question. I think we need to add an IF at the following:
server.js[28]
socket.on('disconnect', function() { if (socket.nickname != null){ users.splice(socket.userIndex, 1); socket.broadcast.emit('system', socket.nickname, users.length, 'logout'); } });

Then other users won't receive useless messages like "system [17:50:51]: null left"

from hichat.

wayou avatar wayou commented on June 15, 2024

ya, I think so. pr is appreciated.

from hichat.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.