GithubHelp home page GithubHelp logo

Bug fix suggestion about pypub HOT 1 CLOSED

wcember avatar wcember commented on August 19, 2024 1
Bug fix suggestion

from pypub.

Comments (1)

dazuraz avatar dazuraz commented on August 19, 2024

One more bug in the following method:

def _get_image_urls(self):
    image_nodes = self._content_tree.find_all('img')
    raw_image_urls = [node['src'] for node in image_nodes if node.has_attr('src')]
    full_image_urls = [urlparse.urljoin(self.url, image_url) for image_url in raw_image_urls]
    image_nodes_filtered = [node for node in image_nodes if node.has_attr('src')]
    return zip(image_nodes_filtered, full_image_urls)

Method urlparse.urljoin does not handle the case where self.url is a local file. Parameter full_image_urls will have the wrong values for any local file images.

from pypub.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.