Comments (1)
One more bug in the following method:
def _get_image_urls(self):
image_nodes = self._content_tree.find_all('img')
raw_image_urls = [node['src'] for node in image_nodes if node.has_attr('src')]
full_image_urls = [urlparse.urljoin(self.url, image_url) for image_url in raw_image_urls]
image_nodes_filtered = [node for node in image_nodes if node.has_attr('src')]
return zip(image_nodes_filtered, full_image_urls)
Method urlparse.urljoin
does not handle the case where self.url
is a local file. Parameter full_image_urls
will have the wrong values for any local file images.
from pypub.
Related Issues (10)
- Documentation link broken HOT 2
- Set Ebook Cover?
- python 3 compatible HOT 1
- xmlprettify can cause mangled output HOT 1
- add cover to epub HOT 1
- Importing pypub HOT 3
- Problem with diacritic sign. HOT 1
- Entity 'nbsp' not defined HOT 1
- error Entity not defined HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pypub.