Use linter exit code to determine check result about lint-action

[larsklevan]

It probably makes sense to use the linter's exit code to determine the check conclusion

I like this approach. Seems like it would be consistent with the way CI typically works.

[larsklevan]

Thank you for the quick fix! I tried it with rubocop in my project and it's working great.

[samuelmeuli]

It probably makes sense to use the linter's exit code to determine the check conclusion.

I've been considering adding a [linter]_args opition anyway, which would also make sense in this situation. It would allow users to change what types of offenses RuboCop returns a non-zero exit code for (with the --fail-level flag).

[samuelmeuli]

Unfortunately, not all tools use a non-zero exit code when issues are found (e.g. gofmt doesn't). For these tools, the Lint Action should continue using the number of lint errors to determine the check status.

[larsklevan]

Yeah, it looks like gofmt is a bit of an oddball:
golang/go#24230