Comments (4)
Yes, we have to resolve this issue. Roughly speaking, the rust LoaderItem
(i.e. the LoaderObject
counterpart in webpack) is immutable. To make it work with LoaderContext["data"]
, we need to change it to mutable and pass loader object with data instead of passing loader identifiers (upon which we create LoaderObject
in loader runner on JS side) to JS to solve this issue.
from rspack.
This is highly related with the current loader impl.
Normally, webpack loaders, in a single loader pipeline, share the same loader context with loaders in both pitching and normal stage. That is said the LoaderContext["data"]
is shared as well. In rspack, after the pitching loader, the JavaScript loader runner will yield and give control back to Rust loader runner to load resources (loader runner's process_resource
hook). This results in the data
being lost.
from rspack.
Get it 👍
I found this issue when using the cache-loader, it is not urgent. If we can solve this issue, Rspack users can use cache-loader to speed up rebuild, which will be a practical approach before we support portable cache.
from rspack.
This also needs to dynamically add fields on data
. Maybe we can refer to #6631 's implementation of saving data only on the js side?
from rspack.
Related Issues (20)
- [Bug]: rspack.SourceMapDevToolPlugin generated sourcemaps are different from the original source
- [Bug]: Rspack doesn't consider `resolve.extensions` when loading default entry
- [Feature]: Rspack能否支持,像vite那样,使用?raw标记,即可将资源文件转换为字符串 HOT 3
- [Bug]: 使用assest/source 导出的文件内容不全 HOT 1
- [Bug]: Externals config object does not work in librarytarget "umd" HOT 2
- [Bug]: When open the concanatedModules of rspack,the lodash-es has value scope error HOT 1
- don't include rspack_version runtime into library mode
- A prototype (empty object) was mistakenly added to the arrow functions HOT 2
- [Feature]: support more command-line flags HOT 6
- [Bug]: import is removed if not used even if the module has sideEffect HOT 1
- [Bug]: vue2中使用了jsx然后用builtin:swc-loader替换babel-loader去编译.js文件会报错
- [Bug]: doesn't render anything when using `lazyCompilation` HOT 3
- [Bug]: __webpack_require__ is not renamed when conflict with webpack's own __webpack_require__
- refactor: enable more lints clippy rules HOT 2
- [Feature]: karma-rspack HOT 1
- [Feature]: provide better comment annotation HOT 11
- [Bug]: When dealing with browser compatibility, certain files can never be processed
- [Bug]: an error occurred when formatting an argument HOT 2
- [Bug]: 使用defineConfig中的plugins注册VueLoaderPlugin()编译报错缺少 'webpack/lib/rules/BasicEffectRulePlugin' HOT 3
- [Bug]: internal error: entered unreachable code HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rspack.