GithubHelp home page GithubHelp logo

Comments (8)

github-actions avatar github-actions commented on July 26, 2024 1

Hello @exocornet, sorry we can't investigate the problem further without reproduction demo, please provide a repro demo by forking rspack-repro, or provide a minimal GitHub repository by yourself. Issues labeled by need reproduction will be closed if no activities in 14 days.

from rspack.

exocornet avatar exocornet commented on July 26, 2024 1

Hello, I provide a repository
https://github.com/exocornet/express-template/tree/rspack

File rspack.config.js 139 line. I had to disable caching to work correctly locally, but the collector began to work slower.
https://github.com/exocornet/express-template/blob/rspack/rspack.config.js

I connect the fonts in fonts.scss
https://github.com/exocornet/express-template/blob/rspack/src/shared/styles/layer-generic/fonts.scss

I also have two more questions:

  1. Will there be plugin support webpack-remove-empty-scripts? It doesn't work now, you have to do it with additional code in file server.js 208 - 220 line.
    webpack-remove-empty-scripts
    https://github.com/exocornet/express-template/blob/rspack/server.js

  2. Will there be full support for the plugin in the near future image-minimizer-webpack-plugin? It is sorely missed the way it worked before.

Thanks for the help and quick response.

from rspack.

LingyuCoder avatar LingyuCoder commented on July 26, 2024 1

cc @jerrykingxyz , seems to be a bug of incremental build while handling assets, I made a more simple repro here, just rspack serve and modify the other.css

from rspack.

jerrykingxyz avatar jerrykingxyz commented on July 26, 2024 1

@exocornet you can try set output.clean to false to workaround. The other two questions about plugin compatibility @h-a-n-a cc

from rspack.

exocornet avatar exocornet commented on July 26, 2024

cc @jerrykingxyz , seems to be a bug of incremental build while handling assets, I made a more simple repro here, just rspack serve and modify the other.css

Hello. Yes, that's right, that's true. But webpack did not have this bug. Can you please tell me how to solve this problem? And also tell me, with the other two questions, are there already answers or solutions?

from rspack.

exocornet avatar exocornet commented on July 26, 2024

@exocornet you can try set output.clean to false to workaround. The other two questions about plugin compatibility @h-a-n-a cc

Thank you very much, everything works. But I would like to have support like in webpack. And so I have to set isProd for clean. Although this may be more correct for local assembly, here I rely on your expertise.

@h-a-n-a Hello, I was advised to contact you regarding the two questions above. Can you suggest something?

I also have two more questions:

Will there be plugin support webpack-remove-empty-scripts? It doesn't work now, you have to do it with additional code in file server.js 208 - 220 line.
webpack-remove-empty-scripts
https://github.com/exocornet/express-template/blob/rspack/server.js

Will there be full support for the plugin in the near future image-minimizer-webpack-plugin? It is sorely missed the way it worked before.

Thanks for the help and quick response.

from rspack.

h-a-n-a avatar h-a-n-a commented on July 26, 2024

@exocornet you can try set output.clean to false to workaround. The other two questions about plugin compatibility @h-a-n-a cc

Thank you very much, everything works. But I would like to have support like in webpack. And so I have to set isProd for clean. Although this may be more correct for local assembly, here I rely on your expertise.

@h-a-n-a Hello, I was advised to contact you regarding the two questions above. Can you suggest something?

I also have two more questions:
Will there be plugin support webpack-remove-empty-scripts? It doesn't work now, you have to do it with additional code in file server.js 208 - 220 line.
webpack-remove-empty-scripts
https://github.com/exocornet/express-template/blob/rspack/server.js
Will there be full support for the plugin in the near future image-minimizer-webpack-plugin? It is sorely missed the way it worked before.

Thanks for the help and quick response.

The plugin's relying on a few hooks that does quite expensive jobs on the JS side. We're not likely to support this.
https://github.com/webdiscus/webpack-remove-empty-scripts/blob/84157f850976c00474a97cc954f2a9837c2c0347/src/index.js#L53-L102

from rspack.

h-a-n-a avatar h-a-n-a commented on July 26, 2024

Since the bug has been resolved, I will close this issue.

from rspack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.