GithubHelp home page GithubHelp logo

Comments (6)

h-a-n-a avatar h-a-n-a commented on July 26, 2024 1

In the release artifact, which you've been using, symbols are stripped. This results in the backtrace or the stack telling nothing useful for debugging. Would you please try to reproduce it so we can proceed?

from rspack.

h-a-n-a avatar h-a-n-a commented on July 26, 2024 1

Great repro! I was able to reproduce it locally. A fix is coming right over.

from rspack.

github-actions avatar github-actions commented on July 26, 2024

Hello @markmssd, sorry we can't investigate the problem further without reproduction demo, please provide a repro demo by forking rspack-repro, or provide a minimal GitHub repository by yourself. Issues labeled by need reproduction will be closed if no activities in 14 days.

from rspack.

markmssd avatar markmssd commented on July 26, 2024

Ah ok. I'll keep trying. So far I noticed that by using the builtin swc, it's working, and it crashes or hangs only when using our own (by using require.resolve). Not sure if that's related, but I did see an upgrade of swc_core in Rspack, so maybe? I'll re-update once I have a repro.

from rspack.

markmssd avatar markmssd commented on July 26, 2024

Alright so using a custom loader, I was indeed able to reproduce it: https://github.com/markmssd/rspack-hmr-performance-regression/tree/swc-custom-loader!

  • This repro uses Rspack 0.7.3, but it's the same with 0.7.4-canary
  • Downgrading to Rspack 0.7.2 works without problem
  • On 0.7.3, if you use the builtin loader (uncomment here and comment the one below it), it also works
  • In this repro, I haven't used the latest SWC/SWC Helpers version, but it's the same with latests
  • In this repro, I get a different error than in my personal project, possibly because it's different code and crashes at a different place, but it's crashing as expected.

Steps to reproduce:

git clone https://github.com/markmssd/rspack-hmr-performance-regression/tree/swc-custom-loader
cd rspack-hmr-performance-regression
npm install --force
npm start
Screenshot 2024-06-14 at 9 12 07β€―AM

Let me know if I can provide anything more to help!

from rspack.

markmssd avatar markmssd commented on July 26, 2024

Thanks @h-a-n-a ! πŸš€ I'll wait for the next release to re-test it (issue is still happening with 0.7.4-canary-bdc2037-20240617004808, so I guess it doesn't include this fix yet)

from rspack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.