GithubHelp home page GithubHelp logo

Comments (14)

KaminoU avatar KaminoU commented on May 7, 2024 2

seen it (- Updating hessam/laravel-blogger (v7.0.1 => v7.0.2): Downloading (100%)
)

thx =)

from blogetc.

christopherokonkwo avatar christopherokonkwo commented on May 7, 2024 1

That's good of you.

from blogetc.

KaminoU avatar KaminoU commented on May 7, 2024 1

@vhessam

works like a charm, thx =)

@WebDevEtc @vhessam

I believe that there are 2 missing important conditions in BlogEtcReaderController@index :

$posts = $posts->where('is_published', '=', 1)->where('posted_at', '<', Carbon::now()->format('Y-m-d H:i:s'))->orderBy("posted_at", "desc")->paginate(config("blogetc.per_page", 10));

Without the is_published condition, and the posted_at condition, the draft and delayed post are listed and that is not what we do really want...

Thx for reading

Cheers

from blogetc.

samberrry avatar samberrry commented on May 7, 2024 1

@KaminoU
I checked it. You are right, it shows the posts which specified to be not published.
I also consider it in search..
I'm gonna add what you said..
thanks for your help

from blogetc.

samberrry avatar samberrry commented on May 7, 2024 1

@KaminoU
I updated the package and added your snippet thank you so much.
Also I made a change on search package and made pull request.
swisnl/laravel-fulltext#23
After my request is approved I'll update the package for its dependencies. That change will solve search page issue.
tnx ;)

from blogetc.

samberrry avatar samberrry commented on May 7, 2024

@christopherokonkwo I shared my experience for analyzing different Laravel blog systems.
You can check it at my blog: https://hessam.binshops.com/story-about-laravel-blogs

from blogetc.

samberrry avatar samberrry commented on May 7, 2024

@KaminoU Thanks for your help :) I'm pursuing to fix problems.

from blogetc.

WebDevEtc avatar WebDevEtc commented on May 7, 2024

Hey,
Thanks for doing this. I meant to release a new version months ago, but then work & life got in the way!

I've just updated this package (webdevetc/blogetc) to work with latest Laravel version.

(I dropped you an email to say thanks too )

from blogetc.

samberrry avatar samberrry commented on May 7, 2024

@WebDevEtc

thanks for this too much helpful package. Light weight and very great.

from blogetc.

samberrry avatar samberrry commented on May 7, 2024

For legecy support it would better to refer to my repository, because I support it and fix any problems when one is reported, as you do not have too much time to see pull requests.
I work on the package and add some features too..

from blogetc.

samberrry avatar samberrry commented on May 7, 2024

@WebDevEtc
I support the legacy and there is no problem, I have time to do that. You would update readme file to refer to my repo: https://github.com/vhessam/laravel-blogger or add me as a contributor for legacy support. The community will grow more if we contribute together.

Again many thanks for this useful package.

from blogetc.

samberrry avatar samberrry commented on May 7, 2024

I'm open to accept any suggestion.
Many thanks ;)

from blogetc.

WebDevEtc avatar WebDevEtc commented on May 7, 2024

Hi
feel free to do PRs on this package.
I don't see any reason to split it up onto a different package, it makes upgrading for anyone a big pain - they would then have to remove webdevetc/blogetc, and then add vhessam/laravel-blogger.
I do see the hole that I've dug myself be starting to do a big refactor. I might just slowly upgrade the current (legacy) one with the new changes bit by bit, will be easier than having a huge migration guide to a new version.

from blogetc.

samberrry avatar samberrry commented on May 7, 2024

yes you are right, but if you check issues.. I started the new package 1 month after my first issue.
So talking about PRs needs short time for example.. maximum 2 days..or 3 days.. when I started to change the code, community helped me to improve it really... that's why I did not work only on my local system, and I shared that through a new repository.
We all help each other to improve codes. As you see I can update code for a bug fix for a report in hours and respond to reports... and I'll work on legacy and wanna add features.. that could results the WebEtc package be out dated.
You can just focus on new version. Anyway it's up to you.

Many thanks for your valuable work.

from blogetc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.