An error in a test seems to block my ability to end() the client about webdriverio

[bingomanatee]

along those lines: the idea that showTest method simply shows a line on the screen is not in keeping with any test system currently in use in JavaScript.

Most systems capture and log errors when test conditions are not valid;

The accepted practice in testing is to throw an informational error as in:

    client.showTest = function(theTest, receivedValue, expectedValue, message) {
        if (!theTest){
            throw new chai.AssertionError({actual: receivedValue, expected: expectedValue, message: message})
        }
    };

While using a test-system-resident error class isn't the way to go for general practice, this does seem to be the pattern for general use.

[christian-bromann]

Hi @bingomanatee

webdriverjs should not stop or fall in an endless pause because of chai. I tried to reconstructed this use case with the following test:

it.only('should not stop if chai assert fails',function(done) {
    client
        .url(testpageURL)
        .isVisible('.btn1_clicked',function(result){
            assert.strictEqual(false,true);
            done();
        });
});

This test fails but it ended. I stumpled several times on a similar problem when I executed the end function without creating a new session with init before the next test started. Did you find a solution for that?

greetings

[christian-bromann]

Ok, I've probably found the reason why the test stops.

In this line the callback of the current command gets fired after the respond arrived. In this callback a error could be thrown by any assertion library like chai. This stops the process and the next command self.next(); never gets fired to continue with the next command.

The test above works, because no other test waited for execution. The after function was executed and ended the test.

I will wrap this part of code in a try catch to avoid this.

thanks for filing this issue!

[christian-bromann]

Ok..a try catch doesn't work because the Chai Assertion error never gets thrown and a falsely test gets marked as true.

[christian-bromann]

Now I found a nice solution.

process.on('uncaughtException', function (exception) {
    self.next();
});

If the Chai (or whatever you use) error gets thrown, this callback continues the command queue.

[roderickhsiao]

Thanks for your fix Christian, would like to know approximately when will be the release date for the fix (v0.7?) on npm?

Cheers

[christian-bromann]

now ;-)

[roderickhsiao]

Try the latest version and it works !
Just need to perhaps add 'err' for like function(err, results) if you has custom method (previous no 'err' param)

Thanks a lot