GithubHelp home page GithubHelp logo

Comments (7)

psivesely avatar psivesely commented on May 29, 2024 1

I'll try to test w/ 6.0.8 when I have the time.

from tor-browser-selenium.

gunesacar avatar gunesacar commented on May 29, 2024

@fowlslegs thanks for reporting the issue, it seems execute_script returns an empty string.

I couldn't reproduce the issue with TBB 6.5, though. The CI tests pass as well: https://travis-ci.org/webfp/tor-browser-selenium/builds/199167351

Could it be about the selenium version being used? I use 2.53.6.

from tor-browser-selenium.

psivesely avatar psivesely commented on May 29, 2024

The CI tests pass as well: https://travis-ci.org/webfp/tor-browser-selenium/builds/199167351

You don't test this method in Travis: https://github.com/webfp/tor-browser-selenium/blob/v0.2.1/tbselenium/test/test_addons.py#L56.

Could it be about the selenium version being used? I use 2.53.6.

Same here.

from tor-browser-selenium.

gunesacar avatar gunesacar commented on May 29, 2024

You don't test this method in Travis: https://github.com/webfp/tor-browser-selenium/blob/v0.2.1/tbselenium/test/test_addons.py#L56.

Oops, sorry about that 😸

We disabled the test because the Travis containers didn't seem to support WebGL. Could that be the culprit here as well? Does http://webglreport.com/ say your machine/container support WebGL?

Are we sure that the failing test passes with the previous stable (6.0.8)?
I assume you use TB's default security slider setting while running the tests(?)

from tor-browser-selenium.

psivesely avatar psivesely commented on May 29, 2024

This browser supports WebGL 1, but it is disabled or unavailable.

Not sure it passes on 6.0.8.

Security Slider is set to low (although I feel like this is something you might want to explicitly set/ control for the tests).

from tor-browser-selenium.

gunesacar avatar gunesacar commented on May 29, 2024

Thanks, then I suspect the failure is due to lack of WebGL support.

I think we need to rewrite this test. When the test fails we can't tell if it's a genuine failure or it's due to lack of WebGL support.

Security Slider is set to low (although I feel like this is something you might want to explicitly set/ control for the tests).

That makes sense, noted.

from tor-browser-selenium.

gunesacar avatar gunesacar commented on May 29, 2024

Closing this issue. Please reopen if the 6.0.8 test passes on the same machine. Otherwise it should be due to missing WebGL support.

from tor-browser-selenium.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.