GithubHelp home page GithubHelp logo

Comments (5)

unindented avatar unindented commented on July 28, 2024

Same issue here @sokra. ExtractTextPlugin versions 0.3.2 and 0.3.3 in -p mode have terrible performance. Version 0.3.1 seems fine.

I have created a small project to repro this: https://github.com/unindented/webpack-test

With this flag set to true (https://github.com/unindented/webpack-test/blob/6ac62a2253dc2d7334ba98568114c7a53ecf4ce7/webpack.config.js#L15) the ExtractTextPlugin is enabled, and the build takes more than 2 minutes:

$ npm run build

> [email protected] build /tmp/webpack-test
> webpack --colors --progress --profile -p

1236ms build modules
13ms optimize
137012ms build modules
12ms hashing
303ms create chunk assets
2ms additional chunk assets
3306ms optimize chunk assets
0ms optimize assets
5ms emit
Hash: 7de232134287af46b0ee
Version: webpack 1.4.12
Time: 141908ms
      Asset    Size  Chunks             Chunk Names
  common.js  182920       0  [emitted]  common
  mobile.js     364       1  [emitted]  mobile
 desktop.js     365       2  [emitted]  desktop
 mobile.css      17       1  [emitted]  mobile
desktop.css      15       2  [emitted]  desktop
 common.css     175       0  [emitted]  common
   [0] ./config/app.js?Desktop 151 {2} [built]
       factory:8ms building:13ms dependencies:69ms = 90ms
   [0] ./config/app.js?Mobile 151 {1} [built]
       factory:10ms building:16ms dependencies:64ms = 90ms
  [88] ./view_modules/Button/index.js 57 {0} [built]
       ... -> factory:196ms building:275ms
  [89] ./app_modules/Desktop/index.js 54 {2} [built]
       [0] 21ms -> factory:36ms building:35ms = 92ms
  [90] ./app_modules/Mobile/index.js 54 {1} [built]
       [0] 26ms -> factory:32ms building:35ms = 93ms
    + 177 hidden modules

WARNING in common.js from UglifyJs
Dropping unused function argument name [(webpack)/~/node-libs-browser/~/process/browser.js:55,0]
Dropping unused function argument dir [(webpack)/~/node-libs-browser/~/process/browser.js:61,0]
Dropping unused function argument sources [./~/react/lib/Object.assign.js:14,0]
Dropping unused function argument element [./~/react/lib/ReactCompositeComponent.js:726,0]
Dropping unused function argument props [./~/react/lib/ReactCompositeComponent.js:1373,0]
Dropping unused function argument children [./~/react/lib/ReactLegacyElement.js:151,0]
Dropping unused function argument props [./~/react/lib/ReactLegacyElement.js:151,0]
Dropping unused function argument children [./~/react/lib/ReactLegacyElement.js:201,0]
Dropping unused function argument config [./~/react/lib/ReactLegacyElement.js:201,0]
Side effects in initialization of unused variable shim [./~/imports-loader?shim=es5-shim/es5-shim&sham=es5-shim/es5-sham!./~/expose-loader?React!./~/react/react.js:2,0]
Side effects in initialization of unused variable sham [./~/imports-loader?shim=es5-shim/es5-shim&sham=es5-shim/es5-sham!./~/expose-loader?React!./~/react/react.js:3,0]
Dropping unused function argument data [./~/react/lib/monitorCodeUse.js:23,0]
Dropping unused function argument componentName [./~/react/lib/LinkedValueUtils.js:78,0]
Dropping unused function argument componentName [./~/react/lib/LinkedValueUtils.js:93,0]
Dropping unused function argument children [./~/react/lib/ReactElementValidator.js:222,0]
Dropping unused function argument props [./~/react/lib/ReactElementValidator.js:222,0]
Dropping unused function argument props [./~/react/lib/ReactTextComponent.js:37,0]
Dropping unused function argument transaction [./~/react/lib/ReactTextComponent.js:84,0]
Dropping unused function argument nativeEvent [./~/react/lib/getEventModifierState.js:41,0]
Dropping unused function argument i [./~/react/lib/ReactChildren.js:125,0]
Dropping unused function argument name [./~/react/lib/ReactChildren.js:125,0]
Dropping unused function argument child [./~/react/lib/ReactChildren.js:125,0]
Dropping unused function argument traverseContext [./~/react/lib/ReactChildren.js:125,0]
Dropping unused function argument context [./~/react/lib/ReactChildren.js:136,0]
Condition always true [./~/es5-shim/es5-sham.js:15,0]
Dropping unreachable code [./~/es5-shim/es5-sham.js:18,5]
Dropping unused function argument object [./~/es5-shim/es5-sham.js:436,0]
Dropping unused function argument object [./~/es5-shim/es5-sham.js:444,0]
Condition always true [./~/es5-shim/es5-shim.js:15,0]
Dropping unreachable code [./~/es5-shim/es5-shim.js:18,5]
Dropping unused function argument deleteCount [./~/es5-shim/es5-shim.js:355,0]
Dropping unused function argument start [./~/es5-shim/es5-shim.js:355,0]
Dropping unused function argument key [./~/es5-shim/es5-shim.js:880,0]
Side effects in initialization of unused variable array_push [./~/es5-shim/es5-shim.js:47,0]
Dropping unused function argument topLevelTargetID [./~/react/lib/ChangeEventPlugin.js:262,0]
Dropping unused function argument topLevelTarget [./~/react/lib/ChangeEventPlugin.js:261,0]
Dropping unused function argument prevContext [./~/react/lib/ReactDOMInput.js:97,0]
Dropping unused function argument prevState [./~/react/lib/ReactDOMInput.js:97,0]
Dropping unused function argument prevProps [./~/react/lib/ReactDOMInput.js:97,0]
Dropping unused function argument componentName [./~/react/lib/ReactDOMSelect.js:39,0]
Dropping unused function argument prevContext [./~/react/lib/ReactDOMTextarea.js:115,0]
Dropping unused function argument prevState [./~/react/lib/ReactDOMTextarea.js:115,0]
Dropping unused function argument prevProps [./~/react/lib/ReactDOMTextarea.js:115,0]
Dropping unused function argument name [./~/react/lib/ReactErrorUtils.js:25,0]
Dropping unused function argument suffix [./~/react/lib/ReactTestUtils.js:29,0]
Child extract-text-webpack-plugin:
        + 2 hidden modules
Child extract-text-webpack-plugin:
        + 2 hidden modules
Child extract-text-webpack-plugin:
        + 2 hidden modules

With that flag set to false, the ExtractTextPlugin is disabled, and the build takes 5 seconds:

$ npm run build

> [email protected] build /tmp/webpack-test
> webpack --colors --progress --profile -p

1249ms build modules
31ms optimize
13ms hashing
276ms create chunk assets
1ms additional chunk assets
3345ms optimize chunk assets
0ms optimize assets
6ms emit
Hash: 618cabdb997e9d68f132
Version: webpack 1.4.12
Time: 4942ms
     Asset    Size  Chunks             Chunk Names
 common.js  184610       0  [emitted]  common
 mobile.js     507       1  [emitted]  mobile
desktop.js     506       2  [emitted]  desktop
   [0] ./config/app.js?Mobile 151 {1} [built]
       factory:10ms building:16ms dependencies:63ms = 89ms
   [0] ./config/app.js?Desktop 151 {2} [built]
       factory:9ms building:13ms dependencies:68ms = 90ms
  [90] ./view_modules/Button/index.js 57 {0} [built]
       ... -> factory:202ms building:282ms
  [91] ./app_modules/Desktop/index.js 54 {2} [built]
       [0] 22ms -> factory:34ms building:36ms = 92ms
  [92] ./app_modules/Mobile/index.js 54 {1} [built]
       [0] 26ms -> factory:31ms building:36ms = 93ms
    + 177 hidden modules

WARNING in common.js from UglifyJs
Dropping unused function argument name [(webpack)/~/node-libs-browser/~/process/browser.js:55,0]
Dropping unused function argument dir [(webpack)/~/node-libs-browser/~/process/browser.js:61,0]
Dropping unused function argument sources [./~/react/lib/Object.assign.js:14,0]
Dropping unused function argument element [./~/react/lib/ReactCompositeComponent.js:726,0]
Dropping unused function argument props [./~/react/lib/ReactCompositeComponent.js:1373,0]
Dropping unused function argument children [./~/react/lib/ReactLegacyElement.js:151,0]
Dropping unused function argument props [./~/react/lib/ReactLegacyElement.js:151,0]
Dropping unused function argument children [./~/react/lib/ReactLegacyElement.js:201,0]
Dropping unused function argument config [./~/react/lib/ReactLegacyElement.js:201,0]
Side effects in initialization of unused variable shim [./~/imports-loader?shim=es5-shim/es5-shim&sham=es5-shim/es5-sham!./~/expose-loader?React!./~/react/react.js:2,0]
Side effects in initialization of unused variable sham [./~/imports-loader?shim=es5-shim/es5-shim&sham=es5-shim/es5-sham!./~/expose-loader?React!./~/react/react.js:3,0]
Dropping unused function argument data [./~/react/lib/monitorCodeUse.js:23,0]
Dropping unused function argument componentName [./~/react/lib/LinkedValueUtils.js:78,0]
Dropping unused function argument componentName [./~/react/lib/LinkedValueUtils.js:93,0]
Dropping unused function argument children [./~/react/lib/ReactElementValidator.js:222,0]
Dropping unused function argument props [./~/react/lib/ReactElementValidator.js:222,0]
Dropping unused function argument props [./~/react/lib/ReactTextComponent.js:37,0]
Dropping unused function argument transaction [./~/react/lib/ReactTextComponent.js:84,0]
Dropping unused function argument nativeEvent [./~/react/lib/getEventModifierState.js:41,0]
Condition always false [./~/style-loader/addStyles.js:8,0]
Dropping unreachable code [./~/style-loader/addStyles.js:9,0]
Dropping unused function argument i [./~/react/lib/ReactChildren.js:125,0]
Dropping unused function argument name [./~/react/lib/ReactChildren.js:125,0]
Dropping unused function argument child [./~/react/lib/ReactChildren.js:125,0]
Dropping unused function argument traverseContext [./~/react/lib/ReactChildren.js:125,0]
Dropping unused function argument context [./~/react/lib/ReactChildren.js:136,0]
Condition always true [./~/es5-shim/es5-sham.js:15,0]
Dropping unreachable code [./~/es5-shim/es5-sham.js:18,5]
Dropping unused function argument object [./~/es5-shim/es5-sham.js:436,0]
Dropping unused function argument object [./~/es5-shim/es5-sham.js:444,0]
Condition always true [./~/es5-shim/es5-shim.js:15,0]
Dropping unreachable code [./~/es5-shim/es5-shim.js:18,5]
Dropping unused function argument deleteCount [./~/es5-shim/es5-shim.js:355,0]
Dropping unused function argument start [./~/es5-shim/es5-shim.js:355,0]
Dropping unused function argument key [./~/es5-shim/es5-shim.js:880,0]
Side effects in initialization of unused variable array_push [./~/es5-shim/es5-shim.js:47,0]
Condition always false [./~/extract-text-webpack-plugin/loader.js?{"omit":1,"extract":true,"remove":true}!./~/style-loader!./~/css-loader!./~/less-loader!./view_modules/Button/src/Button.less:9,0]
Dropping unreachable code [./~/extract-text-webpack-plugin/loader.js?{"omit":1,"extract":true,"remove":true}!./~/style-loader!./~/css-loader!./~/less-loader!./view_modules/Button/src/Button.less:11,0]
Side effects in initialization of unused variable update [./~/extract-text-webpack-plugin/loader.js?{"omit":1,"extract":true,"remove":true}!./~/style-loader!./~/css-loader!./~/less-loader!./view_modules/Button/src/Button.less:7,0]
Dropping unused function argument topLevelTargetID [./~/react/lib/ChangeEventPlugin.js:262,0]
Dropping unused function argument topLevelTarget [./~/react/lib/ChangeEventPlugin.js:261,0]
Dropping unused function argument prevContext [./~/react/lib/ReactDOMInput.js:97,0]
Dropping unused function argument prevState [./~/react/lib/ReactDOMInput.js:97,0]
Dropping unused function argument prevProps [./~/react/lib/ReactDOMInput.js:97,0]
Dropping unused function argument componentName [./~/react/lib/ReactDOMSelect.js:39,0]
Dropping unused function argument prevContext [./~/react/lib/ReactDOMTextarea.js:115,0]
Dropping unused function argument prevState [./~/react/lib/ReactDOMTextarea.js:115,0]
Dropping unused function argument prevProps [./~/react/lib/ReactDOMTextarea.js:115,0]
Dropping unused function argument name [./~/react/lib/ReactErrorUtils.js:25,0]
Dropping unused function argument suffix [./~/react/lib/ReactTestUtils.js:29,0]

WARNING in mobile.js from UglifyJs
Condition always false [./~/extract-text-webpack-plugin/loader.js?{"omit":1,"extract":true,"remove":true}!./~/style-loader!./~/css-loader!./~/less-loader!./app_modules/Mobile/src/App.less:9,0]
Dropping unreachable code [./~/extract-text-webpack-plugin/loader.js?{"omit":1,"extract":true,"remove":true}!./~/style-loader!./~/css-loader!./~/less-loader!./app_modules/Mobile/src/App.less:11,0]
Side effects in initialization of unused variable update [./~/extract-text-webpack-plugin/loader.js?{"omit":1,"extract":true,"remove":true}!./~/style-loader!./~/css-loader!./~/less-loader!./app_modules/Mobile/src/App.less:7,0]

WARNING in desktop.js from UglifyJs
Condition always false [./~/extract-text-webpack-plugin/loader.js?{"omit":1,"extract":true,"remove":true}!./~/style-loader!./~/css-loader!./~/less-loader!./app_modules/Desktop/src/App.less:9,0]
Dropping unreachable code [./~/extract-text-webpack-plugin/loader.js?{"omit":1,"extract":true,"remove":true}!./~/style-loader!./~/css-loader!./~/less-loader!./app_modules/Desktop/src/App.less:11,0]
Side effects in initialization of unused variable update [./~/extract-text-webpack-plugin/loader.js?{"omit":1,"extract":true,"remove":true}!./~/style-loader!./~/css-loader!./~/less-loader!./app_modules/Desktop/src/App.less:7,0]

from extract-text-webpack-plugin.

unindented avatar unindented commented on July 28, 2024

This seems to have been solved with v0.3.4. @ewiner can you confirm, and maybe we can close this issue?

from extract-text-webpack-plugin.

ewiner avatar ewiner commented on July 28, 2024

Yep, seems to be working again on 0.3.4. Thanks!

from extract-text-webpack-plugin.

unindented avatar unindented commented on July 28, 2024

Maybe you can close the issue @ewiner, to reduce the noise for @sokra?

from extract-text-webpack-plugin.

jsg2021 avatar jsg2021 commented on July 28, 2024

I'm seeing this on webpack 1.10.1 and extract-text-webpack-plugin 0.8.2.

from extract-text-webpack-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.